Ship readme.md/changelog.md in sdists (MANIFEST.in) so sdists build from source#54
Open
sethc555 wants to merge 1 commit into
Open
Ship readme.md/changelog.md in sdists (MANIFEST.in) so sdists build from source#54sethc555 wants to merge 1 commit into
sethc555 wants to merge 1 commit into
Conversation
…eadme.md, so sdists built from this tree could not be installed from source. Verified: with this change, python -m build (sdist -> wheel from that sdist) succeeds in a clean python:3.12 container; without it, it fails. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two related notes: (1) the bug that breaks the RELEASED sdist on PyPI (setup.py importing the package, pulling asn1crypto) is already fixed on this branch's base — a release would fix source installs of the published version; (2) however, HEAD currently has a NEW sdist bug: setup.py reads readme.md, and nothing ships it in sdists, so an sdist cut from HEAD today cannot be installed either. This PR adds the two-line MANIFEST.in fixing that, so the next release's sdist works out of the box.
Verified: with this change,
python -m build(sdist → wheel built from that sdist) succeeds in a clean python:3.12 container; without it, it fails. Found while build-checking popular PyPI packages for source-install breakage (wheelproof).