🔒 Upgrade + Pin GitHub Actions Workflows#268
Merged
Merged
Conversation
Why: GitHub is deprecating Node 20 for JavaScript actions. Setting FORCE_JAVASCRIPT_ACTIONS_TO_NODE24 prevents avoidable CI churn while we keep action versions stable. What changed: added top-level workflow env FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true across active CI/release/test workflows.
This comment has been minimized.
This comment has been minimized.
Why: replace version-tag action refs with commit SHAs for supply-chain hardening, and remove the temporary Node24 env override in favor of proper action upgrades. What changed: upgraded checkout/setup-node/cache/paths-filter/setup-chrome majors, replaced release-beta create-release action, and pinned all workflow uses refs to exact commits.
Vizzly - Visual Test ResultsCLI Reporter - Processing...Build in progress...
|
Robdel12
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
We wanted to fix the Node 20 deprecation path correctly, not paper over it.
The initial env override (
FORCE_JAVASCRIPT_ACTIONS_TO_NODE24) was a temporary safety net. This PR replaces that approach with proper action upgrades and immutable action pinning for workflow supply-chain hardening.What Changed
FORCE_JAVASCRIPT_ACTIONS_TO_NODE24actions/checkout->v6actions/setup-node->v6actions/cache->v5dorny/paths-filter->v4browser-actions/setup-chrome->v2actions/create-release@v1inrelease-beta.ymlwith:softprops/action-gh-release@v2uses:references to immutable commit SHAs, with inline version comments for readability.Verification
npm run lint.github/workflowsto confirm:FORCE_JAVASCRIPT_ACTIONS_TO_NODE24usagesoftprops/action-gh-releaseNotes
This keeps behavior explicit and reviewable while reducing surprise CI drift and improving workflow security posture.