Skip to content

Added composite steps to web app tests#275

Merged
valfirst merged 1 commit intovividus-framework:mainfrom
GrimA9e:web_tests
Apr 30, 2026
Merged

Added composite steps to web app tests#275
valfirst merged 1 commit intovividus-framework:mainfrom
GrimA9e:web_tests

Conversation

@GrimA9e
Copy link
Copy Markdown
Contributor

@GrimA9e GrimA9e commented Apr 29, 2026

Summary by CodeRabbit

  • New Features

    • Added reusable composite login step supporting parameterized credentials
    • Introduced new web application login scenarios
  • Configuration

    • Enhanced Chrome WebDriver configuration for certificate handling
    • Extended engine to discover composite step definitions

@GrimA9e GrimA9e requested a review from a team as a code owner April 29, 2026 15:18
@GrimA9e GrimA9e requested review from uarlouski, valfirst and vkepin and removed request for a team April 29, 2026 15:18
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 29, 2026

📝 Walkthrough

Walkthrough

These changes introduce a new web application login workflow. A composite step definition encapsulates a parameterized login interaction, configuration is updated to discover this step and disable Chrome certificate validation, and two new login scenarios are added while removing an existing deprecated login test flow.

Changes

Cohort / File(s) Summary
Configuration
src/main/resources/properties/suite/web_app/suite.properties
Added Chrome WebDriver flag --ignore-certificate-errors and configured engine to discover composite steps under steps/web_app/*.steps.
Step Definition
src/main/resources/steps/web_app/ui.steps
New composite step defined for login flow: accepts userName and userPassword parameters, enters credentials into username/password fields using name-based selectors, and clicks login button.
Story Files
src/main/resources/story/web_app/Web app login.story, src/main/resources/story/web_app/Web application.story
Added new Web app login story with two scenarios covering basic login flow and credential-generator-based login. Removed deprecated login scenario from Web application story.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main change: adding composite steps to web app tests. The changeset introduces a new composite step definition for login flows and reorganizes test scenarios accordingly.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 60 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 30, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@src/main/resources/properties/suite/web_app/suite.properties`:
- Line 5: The suite currently forces Chrome to ignore TLS errors via the
property web.driver.chrome.command-line-arguments=--ignore-certificate-errors;
remove this default insecure flag and make it opt-in by changing the
configuration so the property is empty by default and can be set per-profile or
via an environment-specific override (e.g., use a profile-specific property key
or support an env var that appends the flag at runtime), update any code that
reads web.driver.chrome.command-line-arguments to fall back to an empty string
if unset and document the opt-in mechanism.

In `@src/main/resources/steps/web_app/ui.steps`:
- Line 4: The step uses a broad XPath locator
"xpath(//button[contains(.,'Log')])" which is flaky; update the locator in the
UI step (the When I click on element located by ... line) to a stricter
selector—prefer an id or data-test attribute (e.g., button with data-test or
id), or use an exact/normalized text XPath such as checking normalized-space()
for "Login" or "Log In" to avoid partial matches; replace the existing
contains(...) locator with that more specific selector so clicks target the
intended submit button.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: eb47bf94-b9b9-48cd-a9b0-3b5d7cba0a7f

📥 Commits

Reviewing files that changed from the base of the PR and between d97ac03 and 5bc9a63.

📒 Files selected for processing (4)
  • src/main/resources/properties/suite/web_app/suite.properties
  • src/main/resources/steps/web_app/ui.steps
  • src/main/resources/story/web_app/Web app login.story
  • src/main/resources/story/web_app/Web application.story
💤 Files with no reviewable changes (1)
  • src/main/resources/story/web_app/Web application.story

Comment thread src/main/resources/properties/suite/web_app/suite.properties
Comment thread src/main/resources/steps/web_app/ui.steps
@valfirst valfirst merged commit 6db91ee into vividus-framework:main Apr 30, 2026
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants