Added composite steps to web app tests#275
Conversation
📝 WalkthroughWalkthroughThese changes introduce a new web application login workflow. A composite step definition encapsulates a parameterized login interaction, configuration is updated to discover this step and disable Chrome certificate validation, and two new login scenarios are added while removing an existing deprecated login test flow. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 60 minutes.Comment |
✅ Actions performedReview triggered.
|
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/main/resources/properties/suite/web_app/suite.properties`:
- Line 5: The suite currently forces Chrome to ignore TLS errors via the
property web.driver.chrome.command-line-arguments=--ignore-certificate-errors;
remove this default insecure flag and make it opt-in by changing the
configuration so the property is empty by default and can be set per-profile or
via an environment-specific override (e.g., use a profile-specific property key
or support an env var that appends the flag at runtime), update any code that
reads web.driver.chrome.command-line-arguments to fall back to an empty string
if unset and document the opt-in mechanism.
In `@src/main/resources/steps/web_app/ui.steps`:
- Line 4: The step uses a broad XPath locator
"xpath(//button[contains(.,'Log')])" which is flaky; update the locator in the
UI step (the When I click on element located by ... line) to a stricter
selector—prefer an id or data-test attribute (e.g., button with data-test or
id), or use an exact/normalized text XPath such as checking normalized-space()
for "Login" or "Log In" to avoid partial matches; replace the existing
contains(...) locator with that more specific selector so clicks target the
intended submit button.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: eb47bf94-b9b9-48cd-a9b0-3b5d7cba0a7f
📒 Files selected for processing (4)
src/main/resources/properties/suite/web_app/suite.propertiessrc/main/resources/steps/web_app/ui.stepssrc/main/resources/story/web_app/Web app login.storysrc/main/resources/story/web_app/Web application.story
💤 Files with no reviewable changes (1)
- src/main/resources/story/web_app/Web application.story
Summary by CodeRabbit
New Features
Configuration