Skip to content

Converted story generation prompts to skills#263

Merged
uarlouski merged 1 commit intovividus-framework:mainfrom
GrimA9e:prompts_to_skills
Apr 14, 2026
Merged

Converted story generation prompts to skills#263
uarlouski merged 1 commit intovividus-framework:mainfrom
GrimA9e:prompts_to_skills

Conversation

@GrimA9e
Copy link
Copy Markdown
Contributor

@GrimA9e GrimA9e commented Apr 6, 2026

Summary by CodeRabbit

  • Documentation
    • VIVIDUS API test generation docs: simplified front-matter; argument hint now accepts file path or raw content; require fetching available API steps via an MCP tool (abort if unavailable); add dependency rule to create resources before GET/DELETE; change inline JSON Gherkin keyword to Given; derive ServiceName from OpenAPI title (PascalCase); replace resource-naming rule to use the last meaningful path segment; removed Quality Checklist.
    • VIVIDUS web test generation docs: simplified front-matter and revised description with explicit usage guidance.

@GrimA9e GrimA9e requested a review from a team as a code owner April 6, 2026 16:02
@GrimA9e GrimA9e requested review from ikalinin1, valfirst and vkepin and removed request for a team April 6, 2026 16:02
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 6, 2026

📝 Walkthrough

Walkthrough

Updated two VIVIDUS skill documents: revised front-matter and descriptions; changed step-discovery to require calling an MCP tool matching vividus_get_all_features (abort if unavailable); adjusted API input hint, dependency/creation rules for GET/DELETE, Gherkin examples, ServiceName derivation, and removed the API quality checklist.

Changes

Cohort / File(s) Summary
VIVIDUS API Test Skill
.github/skills/generate-vividus-api-tests/SKILL.md
Front-matter and doc edits: replace agent/model/tools metadata with name/description/argument-hint; change argument-hint to "file path or content"; require fetching steps via an MCP tool matching vividus_get_all_features and abort if unavailable; require explicit prerequisite POST/creation step (annotated !--) for GET/DELETE on possibly-missing resources; change inline JSON Gherkin example from When to Given; derive ServiceName from OpenAPI info.title (PascalCase); remove "Quality Checklist for API Stories"; redefine [resource] as last meaningful path segment (exclude params) and update filename examples.
VIVIDUS Web Test Skill
.github/skills/generate-vividus-web-tests/SKILL.md
Front-matter cleanup: remove agent and model, add name: generate-vividus-web-tests, and revise description (adds "Use when:" guidance); change step-discovery to call an MCP tool matching vividus_get_all_features and explicitly abort when the MCP tool is unavailable; strict rules now require using only steps returned by the MCP tool.

Sequence Diagram(s)

mermaid
sequenceDiagram
participant User
participant Skill
participant MCP_Tool
participant OpenAPI

User->>Skill: Invoke generate-vividus-(api|web)-tests (file path or content)
Skill->>MCP_Tool: Request available steps (match vividus_get_all_features)
alt MCP tool unavailable
    MCP_Tool-->>Skill: No connection / unavailable
    Skill-->>User: Abort with error (stop generation)
else MCP tool available
    MCP_Tool-->>Skill: Return list of steps
    Skill->>OpenAPI: (API skill) Parse provided OpenAPI info.title -> ServiceName (PascalCase)
    Skill-->>User: Generate .story using only MCP-returned steps and dependency annotations (e.g., POST `!--` for GET/DELETE)
end

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main change: converting story generation prompts to skills, which is evident in both modified files (.github/skills/generate-vividus-api-tests/SKILL.md and .github/skills/generate-vividus-web-tests/SKILL.md) and their structural updates to skill definitions.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.github/skills/generate-vividus-api-tests/SKILL.md:
- Line 180: The ServiceName rule and example conflict: update the SKILL.md
ServiceName guideline so the rule and example align by explicitly stating how to
handle tokens like "Swagger" or "OpenAPI" before applying PascalCase; for
example, change the rule to "Strip common prefixes (e.g., 'Swagger', 'OpenAPI'),
then convert the remaining title to PascalCase with spaces removed" and update
the example text near the ServiceName section (the existing `"Swagger Petstore"
→ Petstore` example) to reflect this behavior or alternatively change the
example to a strict PascalCase mapping if you prefer not to strip prefixes
(e.g., `"Swagger Petstore" → SwaggerPetstore`), ensuring the ServiceName rule
and the example under ServiceName are consistent.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: ea7ded63-f208-4688-a5d8-76ff1cfbeaa2

📥 Commits

Reviewing files that changed from the base of the PR and between 6022d13 and 06f6d69.

📒 Files selected for processing (2)
  • .github/skills/generate-vividus-api-tests/SKILL.md
  • .github/skills/generate-vividus-web-tests/SKILL.md

Comment thread .github/skills/generate-vividus-api-tests/SKILL.md Outdated
@GrimA9e GrimA9e force-pushed the prompts_to_skills branch from 06f6d69 to 594666a Compare April 7, 2026 12:54
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.github/skills/generate-vividus-api-tests/SKILL.md:
- Around line 74-75: Make the tool-discovery behavior consistent by updating the
web skill's requirement that currently uses the command form
vividus_get_all_features() to instead require "calling the MCP tool matching
pattern `vividus_get_all_features`" and add the same ABORT clause used in the
API skill (abort if the VIVIDUS MCP tool is not available or not connected and
instruct the user to connect it). Locate the existing web SKILL.md statement
referencing vividus_get_all_features() and replace its wording so it mirrors the
API skill's pattern+ABORT semantics exactly, ensuring both skills use the same
discovery pattern and error-handling language.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 3383dbcd-05c0-4b96-95a1-6d854815904c

📥 Commits

Reviewing files that changed from the base of the PR and between 06f6d69 and 594666a.

📒 Files selected for processing (2)
  • .github/skills/generate-vividus-api-tests/SKILL.md
  • .github/skills/generate-vividus-web-tests/SKILL.md

@GrimA9e GrimA9e force-pushed the prompts_to_skills branch from 594666a to cce8b40 Compare April 7, 2026 13:17
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.github/skills/generate-vividus-api-tests/SKILL.md:
- Line 180: Remove the accidental leading '+' from the markdown heading fragment
that currently reads "+**ServiceName**: Derive from `info.title`..." in SKILL.md
so it renders correctly; update the text to start with "**ServiceName**: ..."
(PascalCase guidance remains unchanged) and scan nearby lines for any other
diff-artifact '+' prefixes and remove them if present.
- Around line 74-75: Replace the direct reference to vividus_get_all_features()
with the canonical MCP-based wording already used earlier: require fetching
available VIVIDUS API steps by calling the MCP tool matching pattern
`vividus_get_all_features` and abort if the MCP tool is not available/connected;
update the sentence that currently references vividus_get_all_features() so it
matches the exact MCP-based phrasing and removes the direct function-call
instruction to avoid conflicting guidance.

In @.github/skills/generate-vividus-web-tests/SKILL.md:
- Around line 91-92: The wording is inconsistent: one place uses the MCP-tool
phrasing and another uses a function-call phrasing `vividus_get_all_features()`;
update the text so both occurrences use the MCP-tool phrasing—refer to the tool
as "MCP tool matching pattern `vividus_get_all_features`" (and remove any
`vividus_get_all_features()` invocation-style wording) so that both the
requirement that the MCP tool must be called and the abort instruction use the
same MCP-tool based phrasing.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: c430154c-8a82-429f-a378-8773dc4825d8

📥 Commits

Reviewing files that changed from the base of the PR and between 594666a and cce8b40.

📒 Files selected for processing (2)
  • .github/skills/generate-vividus-api-tests/SKILL.md
  • .github/skills/generate-vividus-web-tests/SKILL.md

Comment thread .github/skills/generate-vividus-api-tests/SKILL.md
Comment thread .github/skills/generate-vividus-api-tests/SKILL.md Outdated
Comment thread .github/skills/generate-vividus-web-tests/SKILL.md
@GrimA9e GrimA9e force-pushed the prompts_to_skills branch from cce8b40 to a8faa87 Compare April 7, 2026 13:25
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.github/skills/generate-vividus-api-tests/SKILL.md:
- Around line 2-4: The description field for the skill
"generate-vividus-api-tests" is a long single-line YAML value; change it to a
YAML block scalar (e.g., using | or >) for the description key so the long text
becomes a multi-line, human-readable block—update the description: value in
SKILL.md (key: description under name: generate-vividus-api-tests) to use a
block scalar and preserve the existing text content and punctuation.

In @.github/skills/generate-vividus-web-tests/SKILL.md:
- Around line 2-3: The long single-line YAML description under the skill "name:
generate-vividus-web-tests" should be converted to a YAML block scalar for
readability; edit the "description" field so it uses a pipe (|) or greater-than
(>) block scalar and place the multi-sentence 338-character text on subsequent
indented lines, preserving the exact wording and punctuation while breaking
lines for readability to avoid long single-line diffs.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 4ed0f831-02c2-4557-8efa-d0218ed20c9c

📥 Commits

Reviewing files that changed from the base of the PR and between cce8b40 and a8faa87.

📒 Files selected for processing (2)
  • .github/skills/generate-vividus-api-tests/SKILL.md
  • .github/skills/generate-vividus-web-tests/SKILL.md

Comment thread .github/skills/generate-vividus-api-tests/SKILL.md
Comment thread .github/skills/generate-vividus-web-tests/SKILL.md
@uarlouski uarlouski merged commit d97ac03 into vividus-framework:main Apr 14, 2026
1 of 2 checks passed
@GrimA9e GrimA9e deleted the prompts_to_skills branch April 24, 2026 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants