Converted story generation prompts to skills#263
Converted story generation prompts to skills#263uarlouski merged 1 commit intovividus-framework:mainfrom
Conversation
📝 WalkthroughWalkthroughUpdated two VIVIDUS skill documents: revised front-matter and descriptions; changed step-discovery to require calling an MCP tool matching Changes
Sequence Diagram(s)mermaid Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/skills/generate-vividus-api-tests/SKILL.md:
- Line 180: The ServiceName rule and example conflict: update the SKILL.md
ServiceName guideline so the rule and example align by explicitly stating how to
handle tokens like "Swagger" or "OpenAPI" before applying PascalCase; for
example, change the rule to "Strip common prefixes (e.g., 'Swagger', 'OpenAPI'),
then convert the remaining title to PascalCase with spaces removed" and update
the example text near the ServiceName section (the existing `"Swagger Petstore"
→ Petstore` example) to reflect this behavior or alternatively change the
example to a strict PascalCase mapping if you prefer not to strip prefixes
(e.g., `"Swagger Petstore" → SwaggerPetstore`), ensuring the ServiceName rule
and the example under ServiceName are consistent.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: ea7ded63-f208-4688-a5d8-76ff1cfbeaa2
📒 Files selected for processing (2)
.github/skills/generate-vividus-api-tests/SKILL.md.github/skills/generate-vividus-web-tests/SKILL.md
06f6d69 to
594666a
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/skills/generate-vividus-api-tests/SKILL.md:
- Around line 74-75: Make the tool-discovery behavior consistent by updating the
web skill's requirement that currently uses the command form
vividus_get_all_features() to instead require "calling the MCP tool matching
pattern `vividus_get_all_features`" and add the same ABORT clause used in the
API skill (abort if the VIVIDUS MCP tool is not available or not connected and
instruct the user to connect it). Locate the existing web SKILL.md statement
referencing vividus_get_all_features() and replace its wording so it mirrors the
API skill's pattern+ABORT semantics exactly, ensuring both skills use the same
discovery pattern and error-handling language.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 3383dbcd-05c0-4b96-95a1-6d854815904c
📒 Files selected for processing (2)
.github/skills/generate-vividus-api-tests/SKILL.md.github/skills/generate-vividus-web-tests/SKILL.md
594666a to
cce8b40
Compare
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/skills/generate-vividus-api-tests/SKILL.md:
- Line 180: Remove the accidental leading '+' from the markdown heading fragment
that currently reads "+**ServiceName**: Derive from `info.title`..." in SKILL.md
so it renders correctly; update the text to start with "**ServiceName**: ..."
(PascalCase guidance remains unchanged) and scan nearby lines for any other
diff-artifact '+' prefixes and remove them if present.
- Around line 74-75: Replace the direct reference to vividus_get_all_features()
with the canonical MCP-based wording already used earlier: require fetching
available VIVIDUS API steps by calling the MCP tool matching pattern
`vividus_get_all_features` and abort if the MCP tool is not available/connected;
update the sentence that currently references vividus_get_all_features() so it
matches the exact MCP-based phrasing and removes the direct function-call
instruction to avoid conflicting guidance.
In @.github/skills/generate-vividus-web-tests/SKILL.md:
- Around line 91-92: The wording is inconsistent: one place uses the MCP-tool
phrasing and another uses a function-call phrasing `vividus_get_all_features()`;
update the text so both occurrences use the MCP-tool phrasing—refer to the tool
as "MCP tool matching pattern `vividus_get_all_features`" (and remove any
`vividus_get_all_features()` invocation-style wording) so that both the
requirement that the MCP tool must be called and the abort instruction use the
same MCP-tool based phrasing.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: c430154c-8a82-429f-a378-8773dc4825d8
📒 Files selected for processing (2)
.github/skills/generate-vividus-api-tests/SKILL.md.github/skills/generate-vividus-web-tests/SKILL.md
cce8b40 to
a8faa87
Compare
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/skills/generate-vividus-api-tests/SKILL.md:
- Around line 2-4: The description field for the skill
"generate-vividus-api-tests" is a long single-line YAML value; change it to a
YAML block scalar (e.g., using | or >) for the description key so the long text
becomes a multi-line, human-readable block—update the description: value in
SKILL.md (key: description under name: generate-vividus-api-tests) to use a
block scalar and preserve the existing text content and punctuation.
In @.github/skills/generate-vividus-web-tests/SKILL.md:
- Around line 2-3: The long single-line YAML description under the skill "name:
generate-vividus-web-tests" should be converted to a YAML block scalar for
readability; edit the "description" field so it uses a pipe (|) or greater-than
(>) block scalar and place the multi-sentence 338-character text on subsequent
indented lines, preserving the exact wording and punctuation while breaking
lines for readability to avoid long single-line diffs.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 4ed0f831-02c2-4557-8efa-d0218ed20c9c
📒 Files selected for processing (2)
.github/skills/generate-vividus-api-tests/SKILL.md.github/skills/generate-vividus-web-tests/SKILL.md
Summary by CodeRabbit