49 - add explicit nullable declarations#50
Open
mattgorle wants to merge 2 commits intovanilla:masterfrom
Open
Conversation
|
|
|
Just ran into this issue and was about to report it, thanks for sending a patch |
|
Looks like main Vanilla project is abandoned from 2021 https://open.vanillaforums.com/discussion/39558/official-releases-have-ended and things are not getting merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should address #49 by adding the following explicit nullable declarations:
Cli::parse:$argvCli::validateType$defThe underlying issue is not visible when testing with PHP 8.4 and PHPUnit 8, so there is no clear difference when running the test suite.
However, when testing from an external project with PHP 8.4 and PHPUnit 12, two deprecation notices appear before the change and disappear after the change.