Skip to content

vmstat: fix meminfo unit#668

Merged
Krysztal112233 merged 2 commits intouutils:mainfrom
Bluemangoo:fix/vmstat-meminfo
Apr 13, 2026
Merged

vmstat: fix meminfo unit#668
Krysztal112233 merged 2 commits intouutils:mainfrom
Bluemangoo:fix/vmstat-meminfo

Conversation

@Bluemangoo
Copy link
Copy Markdown
Collaborator

@Bluemangoo Bluemangoo commented Apr 9, 2026

Use a simple but not very graceful way to fix the issue.

See more in the issue.

@Bluemangoo Bluemangoo force-pushed the fix/vmstat-meminfo branch from 02708a9 to 537edf5 Compare April 9, 2026 06:52
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 9, 2026

Codecov Report

❌ Patch coverage is 0% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 19.16%. Comparing base (537edf5) to head (251f9b3).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
src/uu/vmstat/src/parser.rs 0.00% 24 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #668   +/-   ##
=======================================
  Coverage   19.16%   19.16%           
=======================================
  Files          68       68           
  Lines       10147    10147           
  Branches      545      545           
=======================================
  Hits         1945     1945           
  Misses       8202     8202           
Flag Coverage Δ
macos_latest 6.74% <ø> (ø)
ubuntu_latest 19.52% <0.00%> (ø)
windows_latest 0.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Franklin-Qi
Copy link
Copy Markdown
Contributor

LGTM 💯

Copy link
Copy Markdown

@robjtede robjtede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

given the output of meminfo is non-standard, this fix lgtm

@Krysztal112233
Copy link
Copy Markdown
Collaborator

oops. historical echoes from the kernel XD.

@Bluemangoo could you please also add a documentation link to this issue? bytesize-rs/bytesize#157

@Krysztal112233 Krysztal112233 merged commit 46b2b1b into uutils:main Apr 13, 2026
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix wrong unit of meminfo parser

4 participants