Skip to content

NP-01 refactor(tui): move PR creation into git actions dialog and remove blocking fetch#3

Merged
uptickmetachu merged 1 commit intomainfrom
explain/np-01
Feb 15, 2026
Merged

NP-01 refactor(tui): move PR creation into git actions dialog and remove blocking fetch#3
uptickmetachu merged 1 commit intomainfrom
explain/np-01

Conversation

@uptickmetachu
Copy link
Copy Markdown
Owner

Motivation

The Git Actions dialog (g key) previously opened slowly because needs_rebase() performed a blocking git fetch on every invocation. Additionally, the PR creation shortcut (p) was a top-level keybinding that cluttered the main key map despite being an infrequent action.

Changes

  • Removed blocking git fetch from needs_rebase() in worktree.py — the dialog now opens instantly using local refs
  • Moved PR creation into the Git Actions dialog as a new [o] option, shown only when no PR exists and status is working/input/review
  • Removed the top-level p keybinding from the TUI app, reducing key map clutter
  • Added create_pr action routing in the git actions callback handler

Test Plan

  • Open the TUI board and press g — verify the dialog opens instantly (no network delay)
  • With a work item in working/input/review status and no existing PR, verify the create pr [o] option appears
  • With a work item that already has a PR, verify the create pr option is hidden
  • Press o in the git actions dialog — verify PR creation flow triggers
  • Verify that p no longer triggers PR creation from the main board view
  • Run uv run pytest to confirm no test regressions

🤖 Generated with Claude Code

…nto it

Remove blocking `git fetch` call from `needs_rebase()` so the git
actions dialog opens instantly using local refs. Move the top-level
`p` PR hotkey into the git dialog as an opt-in `[o]` option, shown
only when no PR exists yet.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@uptickmetachu uptickmetachu added AI_GENERATED PR generated with AI assistance ai-pr/as-is PR generated entirely by vibe kanban labels Feb 15, 2026
@uptickmetachu uptickmetachu merged commit d9b9932 into main Feb 15, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI_GENERATED PR generated with AI assistance ai-pr/as-is PR generated entirely by vibe kanban

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant