Conversation
What was broken QA reported that Talent Manager role users still could not access the open-to-work Talent report. Root cause The previous API fix guarded the Talent JSON and CSV endpoints for administrators only, even though the follow-up requirement allows Talent Manager users too. What was changed Updated the Talent report guard to allow Talent Manager users in addition to administrators and all-reports machine clients. Updated endpoint documentation and Swagger 403 descriptions to match the expanded role access. Any added/updated tests Updated MemberTalentReportGuard tests to allow Talent Manager roles, including the Topcoder-prefixed role claim.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
QA reported that Talent Manager role users still could not access the open-to-work Talent report API.
Root cause
The previous API fix guarded the Talent JSON and CSV endpoints for administrators only, even though the follow-up requirement allows Talent Manager users too.
What was changed
Updated the Talent report guard to allow Talent Manager users in addition to administrators and all-reports machine clients. Updated endpoint documentation and Swagger 403 descriptions to match the expanded role access.
Any added/updated tests
Updated MemberTalentReportGuard tests to allow Talent Manager roles, including the Topcoder-prefixed role claim.
Passed: source ~/.nvm/nvm.sh && nvm use && pnpm test -- member-talent-report
Passed: source ~/.nvm/nvm.sh && nvm use && pnpm lint
Passed: source ~/.nvm/nvm.sh && nvm use && pnpm build
Ran: source ~/.nvm/nvm.sh && nvm use && pnpm test. The full suite still has unrelated existing SFDC and report-directory failures outside the Talent report guard change.