Conversation
What was broken The community challenge listing Type filter displayed challenge types that should not be selectable, including AI, AI Engineering, test/generated types, and duplicate Marathon Match entries. Root cause The filter panel used the raw challenge type list returned by the API, only excluding Topgear Task by name. New or duplicated API challenge type records were therefore rendered directly and persisted in the selected type query state. What was changed Added a visible challenge type whitelist for Challenge, First2Finish, Marathon Match, and Task. The listing filter panel now derives its visible type list from that whitelist, preserves the expected order, removes duplicate type records, and sanitizes selected type values before they reach filter state or query handling. Any added/updated tests Added coverage for visible challenge type derivation and selected type sanitization, including AI, AI Engineering, generated type values, and duplicate Marathon Match values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
The community challenge listing Type filter displayed unsupported challenge types such as AI, AI Engineering, generated test types, and duplicate Marathon Match entries.
Root cause
The filter panel rendered the raw challenge type list returned by the API, with only a single excluded type name. New, duplicated, or generated API type records were therefore exposed as listing filters and could remain in the selected type query state.
What was changed
Added a visible challenge type whitelist for Challenge, First2Finish, Marathon Match, and Task. The filter panel now derives visible types from that whitelist, keeps the expected order, removes duplicate type records, and sanitizes selected type values before updating filter state or query handling.
Any added/updated tests
Added unit coverage for visible challenge type derivation and selected type sanitization, including AI, AI Engineering, generated type values, and duplicate Marathon Match values.