Conversation
What was broken My Submissions showed virus scan failed Marathon Match submissions as Preparing because the status logic only distinguished accepted review summations from the generic queue state. Root cause The Marathon Match submission aggregation dropped raw virusScan and url fields, and the display status helper did not treat failed scan signals as a failed submission state. What was changed Preserved raw scan metadata on Marathon Match attempts and added failed-status detection for virusScan: false, quarantine URLs, and failed raw statuses. Updated My Submissions list and detail rendering to display Failed with failed styling. Any added/updated tests Added submission status tests for failed, quarantined, and pending scan cases. Updated Marathon Match summation tests to verify scan metadata is preserved.
PM-5275: Show failed virus scan submissions
What was broken The challenge submission Filestack picker exposed external import sources such as Google Drive, Dropbox, OneDrive, GitHub, and direct URL for standard submissions. Root cause (if identifiable) The non-Topgear picker configuration explicitly allowed every Filestack source even though only uploaded files can go through the expected file handling path. What was changed Restricted the standard submission picker source list to local file uploads while leaving the existing Topgear URL submission path intact. Any added/updated tests Added FilestackFilePicker coverage to assert standard submissions open Filestack with only the local file system source and Topgear URL submissions still populate URL submission data.
PM-5319: Restrict submission uploads to local files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://topcoder.atlassian.net/browse/PM-5319
https://topcoder.atlassian.net/browse/PM-5275