Conversation
What was broken Active development challenges with shortened phase durations could fail when the schedule was moved from a scheduled launch time to immediately. Dependent phases shifted earlier with the rest of the schedule, but the update could be rejected as if a non-Design phase duration had been shortened. Root cause (if identifiable) Phase shortening validation ran against raw incoming phase end dates before predecessor-derived scheduled start dates were recalculated. For dependent phases, the validator compared the new end date against the old start date and misclassified a whole-schedule shift as a duration reduction. What was changed Moved schedule-shortening validation to run after phase dates are recalculated, using the effective scheduled start and end dates that will be persisted. Removed the now-unused raw request date resolution helpers. Any added/updated tests Added a phase helper regression test covering active non-Design dependent phases moving earlier with unchanged duration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
Active development challenges with shortened phase durations could fail when the schedule was moved from a scheduled launch time to immediately. Dependent phases shifted earlier with the rest of the schedule, but the update could be rejected as if a non-Design phase duration had been shortened.
Root cause (if identifiable)
Phase shortening validation ran against raw incoming phase end dates before predecessor-derived scheduled start dates were recalculated. For dependent phases, the validator compared the new end date against the old start date and misclassified a whole-schedule shift as a duration reduction.
What was changed
Moved schedule-shortening validation to run after phase dates are recalculated, using the effective scheduled start and end dates that will be persisted. Removed the now-unused raw request date resolution helpers.
Any added/updated tests
Added a phase helper regression test covering active non-Design dependent phases moving earlier with unchanged duration.