Allow prioritized list in tag directive#444
Merged
Merged
Conversation
Tags are tried in order and we maintain the existing fallback. Adds `tags` as alias.
There was a problem hiding this comment.
Pull request overview
This PR extends msgp’s tag-directive handling to support a prioritized list of struct tags (tried in order) while preserving the existing fallback behavior to msg and then msgpack. It also adds tags as an alias directive and includes a generated-fixture test to validate the selection rules.
Changes:
- Change field-tag configuration from a single tag name to a priority-ordered list (
tagNames). - Update the
tagdirective to accept multiple tags (including comma-separated lists) and registertagsas an alias. - Add
_generatedfixtures + tests to validate priority selection and fallback behavior.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| parse/getast.go | Reads field names from the first matching non-empty tag in a configured priority list, then falls back to msg and msgpack. |
| parse/directives.go | Adds tags directive alias and parses tag/tags arguments into a priority list stored on FileSet. |
| _generated/custom_tags.go | Adds a go:generate fixture demonstrating tags primary,fallback usage and fallback behavior. |
| _generated/custom_tags_test.go | Tests encoding/decoding and verifies wire keys reflect the configured tag priority and fallback rules. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
philhofer
reviewed
Jun 3, 2026
philhofer
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tags are tried in order and we maintain the existing fallback.
Adds
tagsas alias.