bme688 driver and example#870
Open
hoanga wants to merge 2 commits into
Open
Conversation
Member
|
Hello @hoanga thank for the addition. Can you please add a smoketest to https://github.com/tinygo-org/drivers/blob/dev/smoketest.sh |
Member
|
Also please remove We only care about the human who submitted the PR, not the tools used. |
Author
|
Hello, I have made updates per suggestions. Hopefully, I understood the request properly. I left the note in an (over)attempt to keep attributions however from the explanation regarding tooling, makes sense. If the PRs end up conflicting because of the smoketest add, I will can fix the aftermath depending on which PR goes in first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
This is a driver for the BME688 sensor that is included on the Pimoroni enviro indoor. I have tested this on an available enviro board and confirmed everything but the gas sensors are functional.
links:
https://github.com/pimoroni/enviro
https://shop.pimoroni.com/products/enviro-indoor