Clear CodeQL note alerts (ASI + unused local)#18
Merged
Conversation
- DOMObserver: add missing semicolon after forEach call (js/automatic-semicolon-insertion). - defineGetterDetector: drop unused `const value` assignment; use `void` to keep the getter-triggering property access as a pure side effect (js/unused-local-variable).
Finalize the staged 0.1.1 (dist @/ import leak fix) and roll in the #18 CodeQL note-alert cleanups. Version bumped 0.1.0 -> 0.1.1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves the two outstanding note-level CodeQL alerts on
main.js/automatic-semicolon-insertion—DOMObserver.ts:106;after theforEach(...)call.js/unused-local-variable—defineGetterDetector.ts:174const valuebinding; the property access (which exists only to trigger the getter) is now expressed asvoid …testProp, dropping theeslint-disabletoo.No behavior change.
tsc --noEmitclean.The high-severity
js/path-injectionalert (#3,e2e/serve.mjs) was triaged separately and dismissed as a false positive — the fixture server is 127.0.0.1-only and already guards traversal vianormalize+startsWith(DIST + '/').