feat: add fullauto mode — frequency-band-only horn design#62
Merged
Conversation
Adds a new `fullauto` pipeline mode where the user specifies only a target frequency band (e.g. 500–4000 Hz) and the system derives optimal horn geometry using analytical acoustics formulas, then explores a grid of candidates via FEM. Key changes: - New geometry_designer module with analytical derivation functions - Prescreen mouth_radius/length now optional for fullauto compatibility - HTML report gains geometry columns and Design Summary section - 6 new Nextflow processes wiring the fullauto workflow - 25 unit tests for geometry derivation Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Resolve README.md merge conflict (keep main's formatting) - Fix AttributeError: 'DriverParameters' has no attribute 'power_w' by using getattr() with None fallback in _render_rankings_rows() Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…atures) Merge main into feat/fullauto-mode to resolve html_report.py conflicts. Both the fullauto design_summary_section and the 3D geometry_section are retained. Fix np.trapezoid compat for NumPy <2.0 and align generate_html_report param name (horn_length -> length). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fullautopipeline mode: user specifies only a target frequency band (e.g. 500–4000 Hz), and the system derives optimal horn geometry analytically then explores a grid of candidates via FEMgeometry_designermodule derives mouth radius fromc₀/(2πf_low)and length from quarter-wave to half-wave, generating a focused grid of ~27 candidates (3 profiles × 3 mouth radii × 3 lengths)mouth_radius/lengthmade optional for fullauto compatibilityTest plan
uv run pytest packages/horn-core/tests/test_geometry_designer.py -v— 25/25 passuv run pytest packages/horn-analysis/tests/test_html_report.py -v— 4/4 passuv run pytest packages/horn-analysis/tests/test_prescreen.py -v— 11/11 passnextflow run main.nf -profile docker --mode fullauto --target_f_low 500 --target_f_high 4000 --num_intervals 10— e2e pipelineresults/fullauto/report/auto_report.html— verify geometry columns and design summary🤖 Generated with Claude Code