iPad popoverPresentation fix#294
Open
A-G91 wants to merge 1 commit intotilltue:masterfrom
A-G91:safe-area-fix
Open
iPad popoverPresentation fix#294A-G91 wants to merge 1 commit intotilltue:masterfrom A-G91:safe-area-fix
A-G91 wants to merge 1 commit intotilltue:masterfrom
A-G91:safe-area-fix
Conversation
…w to safeArea. changed 'initItemSize()' to account for leading and trailing safe area'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changed collectionView leading and trailing constraints from superView to safeArea in TLPhotosPickerViewController.xib.
changed 'initItemSize()' to account for leading and trailing safe area.
Reasoning: On iPad, when presenting modally using 'modalPresentationStyle = .popover', the collection view would extend to the anchor and cut off part of the cells in the last column.