Skip to content

GML-2131: Respect configured TigerGraph ports during UI login#44

Merged
chengbiao-jin merged 1 commit into
tigergraph:release_1.4.2from
OmarAyo1:GML-2131-ui-login-tg-ports
Jun 23, 2026
Merged

GML-2131: Respect configured TigerGraph ports during UI login#44
chengbiao-jin merged 1 commit into
tigergraph:release_1.4.2from
OmarAyo1:GML-2131-ui-login-tg-ports

Conversation

@OmarAyo1

@OmarAyo1 OmarAyo1 commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

User description

PR Type

Bug Fix


Description

  • Respect configured TigerGraph gsPort and restppPort during UI login

  • Fix /ui/ui-login incorrectly falling back to pyTigerGraph default RESTPP port 9000

  • Apply the same connection port configuration to both username/password and API-token login paths

  • Prevent valid TigerGraph credentials from being rejected when TigerGraph is exposed on a non-default port such as 14240


Diagram Walkthrough

flowchart LR
  browser["GraphRAG UI login"] --> api["/ui/ui-login"]
  api --> auth["auth()"]
  auth --> config["db_config"]
  config --> ports["gsPort / restppPort"]
  ports --> tg["TigerGraphConnection"]
  tg --> graphs["listGraphs() succeeds"]

File Walkthrough

Relevant files

Bug Fix 1 file

graphrag/app/routers/ui.py
Pass configured TigerGraph gsPort/restppPort into UI login TigerGraphConnection calls


Validation

  • Reproduced the issue with TigerGraph exposed on port 14240

  • Confirmed TigerGraphConnection(..., gsPort=14240, restppPort=14240) succeeds with the same credentials

  • Confirmed the existing /ui/ui-login path fails because it falls back to port 9000

  • Confirmed /ui/ui-login returns 200 OK after passing configured gsPort and restppPort


PR Type

Bug fix


Description

  • Pass configured ports to UI login

  • Fix non-default TigerGraph port authentication


Diagram Walkthrough

flowchart LR
  login["UI login credentials"] 
  auth["auth() connection setup"]
  config["Configured gsPort/restppPort"]
  tg["TigerGraphConnection"]
  graphs["listGraphs()"]

  login -- "calls" --> auth
  config -- "provides ports" --> auth
  auth -- "creates" --> tg
  tg -- "authenticates via configured ports" --> graphs
Loading

File Walkthrough

Relevant files
Bug fix
ui.py
Configure TigerGraph ports for UI authentication                 

graphrag/app/routers/ui.py

  • Adds gsPort from db_config to UI login connections
  • Adds restppPort from db_config to UI login connections
  • Applies port configuration to token and password login paths
+10/-3   

@tg-pr-agent

tg-pr-agent Bot commented Jun 18, 2026

Copy link
Copy Markdown

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Default Ports

Validate that passing None from db_config.get("gsPort") or db_config.get("restppPort") does not override pyTigerGraph constructor defaults when these keys are absent. If pyTigerGraph does not handle None, omit the arguments unless configured.

conn = TigerGraphConnection(
    host=db_config["hostname"],
    gsPort=db_config.get("gsPort"),
    restppPort=db_config.get("restppPort"),

Comment thread graphrag/app/routers/ui.py
@OmarAyo1 OmarAyo1 force-pushed the GML-2131-ui-login-tg-ports branch from 01d1bc0 to 2319b01 Compare June 18, 2026 21:44
@OmarAyo1 OmarAyo1 force-pushed the GML-2131-ui-login-tg-ports branch from 2319b01 to 59ab0aa Compare June 18, 2026 21:48
@OmarAyo1 OmarAyo1 changed the base branch from main to release_1.4.2 June 23, 2026 20:37
@chengbiao-jin chengbiao-jin merged commit f9b27b6 into tigergraph:release_1.4.2 Jun 23, 2026
1 check failed
chengbiao-jin added a commit that referenced this pull request Jun 23, 2026
* GML-2132 Add knowledge graph compatibility check and repair

- Scan an existing graph for installed queries that have drifted from
  the shipped version or are missing
- Repair them in place without rebuilding the knowledge graph
- Refuse repair while a rebuild is in progress and run it under the
  per-graph lock

* GML-2133 Harden document ingestion and unify vertex ID handling

- Reconcile chunks left unfinished by an interrupted run before
  processing new documents
- Write each chunk together with its content so cancellation can't
  leave chunks without content
- Normalize vertex IDs the same way across every ingest path so
  documents with spaces or mixed case in filenames stay consistent
- Re-create installed queries that have drifted from the shipped
  version on initialization
- Surface ingestion failures as clear errors instead of failing silently

* GML-2134 Report per-file upload failures in the ingestion dialog

* GML-2135 Release 1.4.2

- Bump version to 1.4.2
- Update CHANGELOG and README releases
- Add .gitignore
- GML-2131 Honor configured GS/RESTPP ports at login

* GML-2131: Respect configured TigerGraph ports during UI login (#44)

* GML-2131 Guard configured ports in role-resolution connection

- Omit gsPort/restppPort unless configured, matching the auth() path,
  so absent config falls back to pyTigerGraph defaults

* GML-2133 Refine ingestion changes per review

- Restore partitioned batch streaming for documents and chunks
- Check vertex existence through the TigerGraph client instead of
  hand-built requests
- Use lowercase document ids consistently across the batch ingest path

---------

Co-authored-by: omarAyoubi <94470413+OmarAyo1@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants