ignore src/packaging/data for apache rat checks#808
Open
jsanda wants to merge 1 commit intothelastpickle:masterfrom
Open
ignore src/packaging/data for apache rat checks#808jsanda wants to merge 1 commit intothelastpickle:masterfrom
jsanda wants to merge 1 commit intothelastpickle:masterfrom
Conversation
docker-compose stores data files in src/packaging/data, and it was causing the rat checks to fail for me when building locally.
Member
|
I think this would be better solved by sticking to placing generated files under an existing build directories, instead of in the source tree. (and each src module having only the one "build" directory.) Can we move the data directory to be under |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docker-compose stores data files in src/packaging/data, and it was causing the rat checks to fail for me when building locally.