Add fecEntregaBienes property with getter/setter to Shipment class#21
Open
lecano wants to merge 1 commit into
Open
Add fecEntregaBienes property with getter/setter to Shipment class#21lecano wants to merge 1 commit into
lecano wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds support for capturing the date goods are delivered to the carrier on Shipment.
Changes:
- Introduces a new
fecEntregaBienesproperty onShipment. - Adds getter/setter for
fecEntregaBieneswith nullableDateTimetyping.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+361
to
+374
| /** | ||
| * @return DateTime | ||
| */ | ||
| public function getFecEntregaBienes(): ?DateTime | ||
| { | ||
| return $this->fecEntregaBienes; | ||
| } | ||
|
|
||
| /** | ||
| * @param DateTime $fecEntregaBienes | ||
| * | ||
| * @return Shipment | ||
| */ | ||
| public function setFecEntregaBienes(?DateTime $fecEntregaBienes): Shipment |
Comment on lines
+88
to
+93
| /** | ||
| * Fecha de entrega de bienes al transportista. | ||
| * | ||
| * @var DateTime | ||
| */ | ||
| private $fecEntregaBienes; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for tracking the delivery date of goods to the carrier in the
Shipmentmodel. The main change is the introduction of a new property with its corresponding getter and setter methods.Enhancements to the
Shipmentmodel:fecEntregaBienesto store the delivery date of goods to the carrier, including its PHPDoc annotation.getFecEntregaBienes()andsetFecEntregaBienes()methods to access and modify the newfecEntregaBienesproperty.