Fixes #39298 - Use bulk insert for new fact values on persisted hosts#10979
Open
pablomh wants to merge 1 commit intotheforeman:developfrom
Open
Fixes #39298 - Use bulk insert for new fact values on persisted hosts#10979pablomh wants to merge 1 commit intotheforeman:developfrom
pablomh wants to merge 1 commit intotheforeman:developfrom
Conversation
Replace per-fact create! loop with a single insert_all for new facts on persisted hosts. Compose/parent facts (nil values from StructuredFactImporter) are excluded and handled individually. Also initializes @counters with default zero values to prevent potential nil access. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace per-fact
create!loop with a singleinsert_allfor new facts on persisted hosts, reducing DB round-trips by ~94% (108 INSERTs → 6).Changes
fact_importer.rb:add_new_factspartitions into compose facts (nil values, handled individually) and regular facts (bulk inserted viainsert_all)bulk_insert_new_fact_values: new method usingFactValue.insert_allwithunique_by: [:fact_name_id, :host_id]@counters = { added: 0, updated: 0, deleted: 0 }prevents nil accessHow to test
bundle exec rake test TEST=test/unit/fact_importer_test.rb