Fixes #39290 - Add :registration named logger with session markers#10975
Open
pablomh wants to merge 1 commit intotheforeman:developfrom
Open
Fixes #39290 - Add :registration named logger with session markers#10975pablomh wants to merge 1 commit intotheforeman:developfrom
pablomh wants to merge 1 commit intotheforeman:developfrom
Conversation
Add a dedicated :registration named logger for host registration events, independently configurable from the main Rails logger. At the default info level, emits session_start (GET /register) and session_complete (POST /register) with host name, action (created/updated), and wall-clock duration. At debug level, companion Katello PRs emit Candlepin per-call timing and cache HIT/MISS decisions using the same logger. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a dedicated
:registrationnamed logger for host registration events, independently configurable from the main Rails logger.Changes
config/application.rb: Register:registrationas a named loggerregistration_controller.rb: Emitsession_starton GET /register andsession_completeon POST /register with host name, action (created/updated), and wall-clock durationLog output
Why a dedicated logger
The
:registrationnamed logger lets operators enabledebuglevel for registration events without flooding the log with SQL queries or view rendering:At
debuglevel, companion Katello PRs emit Candlepin per-call timing and cache HIT/MISS decisions using the same logger.How to test
bundle exec rake test TEST=test/controllers/api/v2/registration_controller_test.rbsession_startandsession_completelines