Fixes #39272 - Remove outdated references from redhat_register snippet#10965
Conversation
| puppet_enabled = !host_param_true?('skip-puppet-setup') && (host_puppet_server.present? || host_param_true?('force-puppet')) | ||
| salt_enabled = host_param('salt_master') ? true : false | ||
| sles_minor_string = (os_minor == 0) ? '' : "_SP#{os_minor}" | ||
| spacewalk_enabled = host_param('spacewalk_host') ? true : false |
There was a problem hiding this comment.
Is it certain people aren't still using Spacewalk? I recall talking some time ago with some upstream users who were considering moving to Katello from Spacewalk which is forked upstream.
Of course it's so old, but are the Spacewalk bits causing troubles somewhere?
There was a problem hiding this comment.
I honestly don't know how to answer this question. I'm not sure if we're still expected to support it in any way. any thoughts @sideangleside ?
|
@ianballou Seems Spacewalk itself is dead. At one point it was forked by https://www.uyuni-project.org/pages/faq.html and that seems to be the only surviving descendant. I don't know if anyone in the Foreman community uses it, or if it would even be compatible with Foreman provisioning templates. |
Since these are all provisioning templates, users could just put their own custom one in if they really need it. Spacewalk is truly incredibly old and the cleanup here should help reduce our maintenance burden. |
ianballou
left a comment
ianballou
left a comment
There was a problem hiding this comment.
This looks good to me, I tested rendering these via Foreman::Renderer.render.
Remove Spacewalk and RHN references from redhat_register snippet and AutoYaST SLES template, as these services are long discontinued. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jeremylenz
force-pushed
the
fixes-39272-redhat-register-cleanup
branch
from
46ac3fc to
fa9be51
Compare
|
squashed |
2 participants
Remove obsolete Spacewalk/RHN, auto-attach, and subscription pool references from the
redhat_registerprovisioning template snippet, and modernize syspurpose CLI usage.Changes
rhnreg_ks, RHN certs,up2dateconfig) — Spacewalk/RHN Satellite 5 is long obsoletesubscription_manager_poolandsubscription_manager_auto_attachsupport — all orgs are now SCA-only--auto-attachflag from username/password registrationsubscription-manager syspurposesubcommands instead of the deprecated standalone/usr/sbin/syspurposeCLI binary (no longer requires installingsubscription-manager-syspurposepackage)How to test
Prerequisites
A provisioning setup with a RHEL-compatible host, or review the template rendering output.
Steps
syspurpose set-role/set-usage/set-slacommands replaced withsubscription-manager syspurpose role/usage/service-level --setsubscription-manager-syspurposepackage install block removed/usr/sbin/syspurposebinary check removedkickstart_rhsminstead ofredhat_register)bundle exec rake test TEST=test/unit/foreman/renderer_test.rb— all 168 tests should pass🤖 Generated with Claude Code