Add custom server certs installation with foremanctl#4821
Draft
jafiala wants to merge 4 commits intotheforeman:masterfrom
Draft
Add custom server certs installation with foremanctl#4821jafiala wants to merge 4 commits intotheforeman:masterfrom
jafiala wants to merge 4 commits intotheforeman:masterfrom
Conversation
github-actions
Bot
added
Needs tech review
|
The PR preview for 2751aef is available at theforeman-foreman-documentation-preview-pr-4821.surge.sh The following output files are affected by this PR: |
jafiala
commented
May 6, 2026
Comment on lines
+30
to
+31
| //--certs-update-server --certs-update-server-ca | ||
| //Are these^ just unnecessary now? |
Contributor
Author
There was a problem hiding this comment.
@ShimShtein Are these params unnecessary now? I don't see their equivalents in foremanctl.
ShimShtein
reviewed
May 7, 2026
| + | ||
| The options used in the command include the following: | ||
| + | ||
| `--certificate-source=custom_server`:: Sets the certificate source to custom server certificates provided by the user. Automatically generates an internal CA for client certificates and localhost. Server certificate, key, and CA bundle are copied to `/root/certificates/`. |
Member
There was a problem hiding this comment.
I don't think we need to mention the "resting place" of the certificate files here.
a. we gonna change it
b. it's an internal folder, the user does not need to be aware of it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you introducing?
Add installation with custom server certs
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
https://redhat.atlassian.net/browse/SAT-43472
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
Contributor checklists
Please cherry-pick my commits into: