Fix URLs to Red Hat docs#4820
Closed
maximiliankolb wants to merge 1 commit intotheforeman:masterfrom
Closed
Conversation
This patch changes the URL from "en/documentation/" to "en/products/". $ curl --silent -I https://docs.redhat.com/en/documentation/ | rg "^HTTP|^location" HTTP/2 301 location: /en/products $ fd -e adoc -t f | xargs sed --in-place "s@https://docs.redhat.com/en/documentation/@https://docs.redhat.com/en/products/@g"
github-actions
Bot
added
Needs tech review
Contributor
Author
This PR makes it even worse |
Contributor
Author
|
Closed: The fix is to ignore/change the check so that the link check job ignores the URL |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you introducing?
This patch changes the URL from "en/documentation/" to "en/products/".
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
Because the URLs were changed & my downstream CI reports broken links.
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
Alternative idea: use
{RHDocsBaseURL}everwhere. Let me know what you think.Contributor checklists
Please cherry-pick my commits into: