Comment out modules for linking the Helper labs#4819
Merged
jafiala merged 2 commits intotheforeman:masterfrom May 7, 2026
Merged
Comment out modules for linking the Helper labs#4819jafiala merged 2 commits intotheforeman:masterfrom
jafiala merged 2 commits intotheforeman:masterfrom
Conversation
As the CP Helper Labs have entered mainteance mode, commenting out references to them as these will redirect to the older version. JIRA: https://redhat.atlassian.net/browse/SAT-45008
github-actions
Bot
added
Needs tech review
Member
|
Rather than comment them out (which triggeres the Unused modules check), how about simply deleting them? If we need to re-add them in the future, we can always look up the removal commit and reverse it. |
Member
|
|
As the modules will be flagged as unused, removing them completely. These can be added back in at a later point, if needed.
Contributor
Author
|
@aneta-petrova ack removed the modules. |
jafiala
approved these changes
May 7, 2026
jafiala
removed
Needs tech review
jafiala
pushed a commit
that referenced
this pull request
May 7, 2026
* Remove modules for linking the Helper labs As the CP Helper Labs have entered mainteance mode, removing references to them as these will redirect to the older version. JIRA: https://redhat.atlassian.net/browse/SAT-45008 * Remove modules instead of commenting out As the modules will be flagged as unused, removing them completely. These can be added back in at a later point, if needed. --------- Co-authored-by: Akshay Gadhave <agadhave@agadhave-thinkpadt14gen5.rmtin.csb> (cherry picked from commit 5624ed2)
Contributor
|
Cherry-picked into 3.18 with 613d13f |
jsvarova
pushed a commit
to jsvarova/foreman-documentation
that referenced
this pull request
May 7, 2026
* Remove modules for linking the Helper labs As the CP Helper Labs have entered mainteance mode, removing references to them as these will redirect to the older version. JIRA: https://redhat.atlassian.net/browse/SAT-45008 * Remove modules instead of commenting out As the modules will be flagged as unused, removing them completely. These can be added back in at a later point, if needed. --------- Co-authored-by: Akshay Gadhave <agadhave@agadhave-thinkpadt14gen5.rmtin.csb>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the CP Helper Labs have entered mainteance mode, commenting out references to them as these will redirect to the older version.
JIRA:
https://redhat.atlassian.net/browse/SAT-45008
What changes are you introducing?
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
Contributor checklists
Please cherry-pick my commits into: