Resolve snippet that only contains a single item#4764
Draft
maximiliankolb wants to merge 1 commit intotheforeman:masterfrom
Draft
Resolve snippet that only contains a single item#4764maximiliankolb wants to merge 1 commit intotheforeman:masterfrom
maximiliankolb wants to merge 1 commit intotheforeman:masterfrom
Conversation
This patch drops a snippet that only contains a single unordered list item. Instead, the two lines are now part of the three modules that included the snippet before.
|
The PR preview for b8a3516 is available at theforeman-foreman-documentation-preview-pr-4764.surge.sh No diff compared to the current base |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you introducing?
This patch drops a snippet that only contains a single unordered list item. Instead, the two lines are now part of the three modules that included the snippet before.
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
I think that we do not need a snippet for a single line. Open for feedback on this!
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
Doesn't every host belong to exactly one domain and one subnet? It cannot be at two places at the same time, can it?
If anyone knows this: why does only GCE include this snippet? What about all other clouds? What about virtualization solutions?
If we notice that this snippet would make sense for all compute resources, then I would revert it and include it where appropriate.
Contributor checklists
Please cherry-pick my commits into: