Skip to content

Resolve snippet that only contains a single item#4764

Draft
maximiliankolb wants to merge 1 commit intotheforeman:masterfrom
ATIX-AG:drop_unnecessary_snippet
Draft

Resolve snippet that only contains a single item#4764
maximiliankolb wants to merge 1 commit intotheforeman:masterfrom
ATIX-AG:drop_unnecessary_snippet

Conversation

@maximiliankolb
Copy link
Copy Markdown
Contributor

What changes are you introducing?

This patch drops a snippet that only contains a single unordered list item. Instead, the two lines are now part of the three modules that included the snippet before.

Why are you introducing these changes? (Explanation, links to references, issues, etc.)

I think that we do not need a snippet for a single line. Open for feedback on this!

Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)

Doesn't every host belong to exactly one domain and one subnet? It cannot be at two places at the same time, can it?

If anyone knows this: why does only GCE include this snippet? What about all other clouds? What about virtualization solutions?

If we notice that this snippet would make sense for all compute resources, then I would revert it and include it where appropriate.

Contributor checklists

  • I am okay with my commits getting squashed when you merge this PR.
  • I am familiar with the contributing guidelines.

Please cherry-pick my commits into:

  • Foreman 3.18/Katello 4.20 (Satellite 6.19)
  • Foreman 3.17/Katello 4.19
  • Foreman 3.16/Katello 4.18 (Satellite 6.18; orcharhino 7.6 and 7.7)
  • Foreman 3.15/Katello 4.17
  • Foreman 3.14/Katello 4.16 (Satellite 6.17; orcharhino 7.4; orcharhino 7.5)
  • Foreman 3.13/Katello 4.15 (EL9 only)
  • Foreman 3.12/Katello 4.14 (Satellite 6.16; orcharhino 7.2 on EL9 only; orcharhino 7.3)
  • We do not accept PRs for Foreman older than 3.12.

This patch drops a snippet that only contains a single unordered list
item. Instead, the two lines are now part of the three modules that
included the snippet before.
@github-actions github-actions Bot added Needs tech review Requires a review from the technical perspective Needs style review Requires a review from docs style/grammar perspective Needs testing Requires functional testing labels Apr 10, 2026
@github-actions
Copy link
Copy Markdown

The PR preview for b8a3516 is available at theforeman-foreman-documentation-preview-pr-4764.surge.sh

No diff compared to the current base

show diff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs style review Requires a review from docs style/grammar perspective Needs tech review Requires a review from the technical perspective Needs testing Requires functional testing Not yet reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant