Skip to content

Split Administering hosts into multiple assemblies#4758

Merged
aneta-petrova merged 10 commits intotheforeman:masterfrom
aneta-petrova:ustory-administering-hosts
Apr 21, 2026
Merged

Split Administering hosts into multiple assemblies#4758
aneta-petrova merged 10 commits intotheforeman:masterfrom
aneta-petrova:ustory-administering-hosts

Conversation

@aneta-petrova
Copy link
Copy Markdown
Member

What changes are you introducing?

Introducing several smaller, focused assemblies in place of the existing catch-all "Administering hosts" assembly.

Why are you introducing these changes? (Explanation, links to references, issues, etc.)

Each assembly should cover a single user story (this is part of the downstream Content Quality Assessment (CQA) initiative.)

Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)

I'm not changing anything about the modules themselves, I'm just moving them around.

I used the skill from #4723 for a first draft and I'd say it got about half of the changes right on the first try, so it did a lot of heavy lifting for me, which was very useful.

Contributor checklists

  • I am okay with my commits getting squashed when you merge this PR.
  • I am familiar with the contributing guidelines.

Please cherry-pick my commits into:

  • Foreman 3.18/Katello 4.20 (Satellite 6.19)
  • Foreman 3.17/Katello 4.19
  • Foreman 3.16/Katello 4.18 (Satellite 6.18; orcharhino 7.6 and 7.7)
  • Foreman 3.15/Katello 4.17
  • Foreman 3.14/Katello 4.16 (Satellite 6.17; orcharhino 7.4; orcharhino 7.5)
  • Foreman 3.13/Katello 4.15 (EL9 only)
  • Foreman 3.12/Katello 4.14 (Satellite 6.16; orcharhino 7.2 on EL9 only; orcharhino 7.3)
  • We do not accept PRs for Foreman older than 3.12.

@github-actions github-actions Bot added Needs tech review Requires a review from the technical perspective Needs style review Requires a review from docs style/grammar perspective Needs testing Requires functional testing labels Apr 8, 2026
@aneta-petrova aneta-petrova force-pushed the ustory-administering-hosts branch from b70be75 to 61922e5 Compare April 8, 2026 20:44
@aneta-petrova aneta-petrova removed Needs tech review Requires a review from the technical perspective Needs testing Requires functional testing labels Apr 8, 2026
Each assembly should describe a single user story only

Assisted-by: Cursor
@aneta-petrova aneta-petrova force-pushed the ustory-administering-hosts branch from 61922e5 to 6a01de6 Compare April 8, 2026 20:50
@aneta-petrova aneta-petrova marked this pull request as ready for review April 8, 2026 20:57
Copy link
Copy Markdown
Contributor

@maximiliankolb maximiliankolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR overall. I made some suggestions.

= Managing host placement and associations

[role="_abstract"]
Use {Project} to link each host to a compute resource, organization, location, and content view environment.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels very vague to me.

What does "link" mean? You cannot just say "move host A from Azure to GCE". Instead, you'd have to redeploy it and delete the old one. That only works well if you have its configuration as code.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would "associate" work better? That's what I tried to address your comment.


[role="_abstract"]
Use {Project} to link each host to a compute resource, organization, location, and content view environment.
Detach host records when hosts move or retire so your host list stays current.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Detach host records when hosts move or retire so your host list stays current.
Detach host records when hosts move or retire so your host list stays current and {Project} no longer tries to manage it.

Unsure about this too. Does detach mean unregister on the Client or mark as unassociated in Foreman/delete in Foreman?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was an attempt to describe the use case. I struggled to come up with a better one. If the new use case description is off too, then perhaps we don't have to add a use case and the first line of the abstract could also be enough?

Comment thread guides/common/modules/con_managing-host-snapshots.adoc Outdated
Comment thread guides/common/modules/con_reviewing-hosts-in-project-web-ui.adoc Outdated
Comment thread guides/common/assembly_configuring-tracer-and-application-restarts-on-hosts.adoc Outdated
@Lennonka
Copy link
Copy Markdown
Contributor

Lennonka commented Apr 9, 2026

This might be out of scope for this PR, but it would be great if we could move 20. Host status in Foreman under the first chapter Reviewing hosts... Just for your consideration :)

@Lennonka Lennonka added the Waiting on contributor Requires an action from the author label Apr 9, 2026
Co-authored-by: Maximilian Kolb <mail@maximilian-kolb.de>
@pr-processor pr-processor Bot added Needs re-review and removed Waiting on contributor Requires an action from the author labels Apr 13, 2026
@aneta-petrova
Copy link
Copy Markdown
Member Author

This might be out of scope for this PR, but it would be great if we could move 20. Host status in Foreman under the first chapter Reviewing hosts... Just for your consideration :)

Still within the scope of creating a new assembly and a good idea, thanks! Implemented.

@aneta-petrova
Copy link
Copy Markdown
Member Author

I addressed all comments, and would appreciate @maximiliankolb's re-review to see if I interpreted his hints correctly.

@aneta-petrova aneta-petrova force-pushed the ustory-administering-hosts branch from 370478e to 7e96489 Compare April 13, 2026 10:21
Copy link
Copy Markdown
Contributor

@Lennonka Lennonka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maximiliankolb
Copy link
Copy Markdown
Contributor

@aneta-petrova I can have a look at it on Monday. Please ping me if there's no comment by Monday 3pm.

= Managing host placement and associations

[role="_abstract"]
Use {Project} to associate each host with a compute resource, organization, location, and content view environment.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is unclear to me. What do you mean by "associate"?

I would split this: You can assign an org/loc to a host; a host may run on a compute resource (unless bare metal); a host may have a CV env (if katello; even then it is optional IMHO).

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's proving difficult to meet the requirements for abstracts when the assembly is somewhat generic :/ The guidelines I'm working with are written down in https://github.com/theforeman/foreman-documentation/pull/4778/changes. And I'm trying to avoid just listing the features in the included procedures because that's not what an abstract should be about.

I gave this another try. This time, I'm carefully avoiding the verb 'associate' and also the term 'infrastructure resources'. I thought that perhaps 'context-defining resources' could work? I'm just trying to find one term that describes the stuff you use to manage the hosts in the procedures included in the assembly :) What do you think now @maximiliankolb? Am I getting closer to something acceptable?


[role="_abstract"]
Use {Project} to associate each host with a compute resource, organization, location, and content view environment.
This helps you keep your hosts aligned with appropriate infrastructure resources.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also unclear to me.

Comment thread guides/common/modules/con_reviewing-hosts-in-project-web-ui.adoc Outdated
@pr-processor pr-processor Bot added the Waiting on contributor Requires an action from the author label Apr 20, 2026
Co-authored-by: Maximilian Kolb <mail@maximilian-kolb.de>
@pr-processor pr-processor Bot added Needs re-review and removed Waiting on contributor Requires an action from the author labels Apr 20, 2026
Copy link
Copy Markdown
Contributor

@maximiliankolb maximiliankolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last suggestion.

Comment thread guides/common/modules/con_managing-host-placement-and-associations.adoc Outdated
Co-authored-by: Maximilian Kolb <mail@maximilian-kolb.de>
@aneta-petrova aneta-petrova force-pushed the ustory-administering-hosts branch from 3d1b111 to 9ce5abc Compare April 21, 2026 06:49
Copy link
Copy Markdown
Contributor

@maximiliankolb maximiliankolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Anet, LGTM.

@maximiliankolb maximiliankolb added style review done No issues from docs style/grammar perspective and removed Needs style review Requires a review from docs style/grammar perspective labels Apr 21, 2026
@aneta-petrova aneta-petrova merged commit 9f4cabf into theforeman:master Apr 21, 2026
10 of 11 checks passed
@aneta-petrova aneta-petrova deleted the ustory-administering-hosts branch April 21, 2026 12:37
aneta-petrova added a commit that referenced this pull request Apr 21, 2026
* Split Administering hosts into multiple assemblies

Each assembly should describe a single user story only

Assisted-by: Cursor

---------

Co-authored-by: Maximilian Kolb <mail@maximilian-kolb.de>
(cherry picked from commit 9f4cabf)
(cherry picked from commit b7b0b1e)
aneta-petrova added a commit that referenced this pull request Apr 21, 2026
* Split Administering hosts into multiple assemblies

Each assembly should describe a single user story only

Assisted-by: Cursor

---------

Co-authored-by: Maximilian Kolb <mail@maximilian-kolb.de>
(cherry picked from commit 9f4cabf)
aneta-petrova added a commit that referenced this pull request Apr 21, 2026
* Split Administering hosts into multiple assemblies

Each assembly should describe a single user story only

Assisted-by: Cursor

---------

Co-authored-by: Maximilian Kolb <mail@maximilian-kolb.de>
(cherry picked from commit 9f4cabf)
@aneta-petrova
Copy link
Copy Markdown
Member Author

Merged to "master" and cherry-picked:

jsvarova pushed a commit to jsvarova/foreman-documentation that referenced this pull request May 4, 2026
* Split Administering hosts into multiple assemblies

Each assembly should describe a single user story only

Assisted-by: Cursor

---------

Co-authored-by: Maximilian Kolb <mail@maximilian-kolb.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

style review done No issues from docs style/grammar perspective

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants