feat(cooling): surface make-up water system on miners circuit 1#121
Merged
eskawl merged 1 commit intoJul 3, 2026
Merged
Conversation
Extract the makeup block builder shared with circuit 2 and include it in the circuit 1 and layout views. The make-up pump now comes only in the makeup block instead of the circulation pumps array, the tank description carries its volume, on/off valves report is_open from the valve status, and the circuit 1 projection fetches levels and tanks.
tekwani
approved these changes
Jul 3, 2026
boris91
approved these changes
Jul 3, 2026
eskawl
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Serves the make-up water system on the miners circuit 1 view (it was only on circuit 2)
makeupin the circuit 1 and layout views; equipment ids and defaults come fromcooling_system.makeup, with per-circuit override still supportedpumpsarray — it only appears inmakeup.pump, which also restores the pumps[0/1/2] = A/B/C layout contractrated_head/rated_flowso the FE can renderdescriptionwith its volume,is_openfrom valve status instead of position > 50%, since XV valves have no position feedbacklevelsandtanksfor the tank level