Skip to content

JUnit summary with failures#9912

Open
stephanos wants to merge 1 commit intomainfrom
stephanos/failure-log
Open

JUnit summary with failures#9912
stephanos wants to merge 1 commit intomainfrom
stephanos/failure-log

Conversation

@stephanos
Copy link
Copy Markdown
Contributor

@stephanos stephanos commented Apr 10, 2026

What changed?

Add failure details per test to GitHub summary view.

Why?

Avoid digging through logs.

How did you test it?

  • built
  • run locally and tested manually
  • covered by existing tests
  • added new unit test(s)
  • added new functional test(s)

Example:

Screenshot 2026-04-13 at 1 58 43 PM

https://github.com/temporalio/temporal/actions/runs/24366106128?pr=9912

@stephanos stephanos force-pushed the stephanos/failure-log branch 3 times, most recently from a3de11e to 25cd028 Compare April 10, 2026 19:44
detailed_summary: true
check_annotations: false
annotate_only: true
skip_annotations: true
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mikepenz/action-junit-report doesn't support showing failure details.

@stephanos stephanos force-pushed the stephanos/failure-log branch 19 times, most recently from 9091a7f to 8182970 Compare April 11, 2026 23:26
echo "::notice::Job ID for '$JOB_NAME' not visible yet (attempt $attempt/6); retrying in 5s"
sleep 5
fi
done
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude suggested doing retries here and I thought that was a good idea; wouldn't want to fail the run because of this being flaky.

@stephanos stephanos force-pushed the stephanos/failure-log branch 6 times, most recently from 38fe804 to 917d180 Compare April 13, 2026 16:22
@stephanos stephanos force-pushed the stephanos/failure-log branch 14 times, most recently from 5ba0dd9 to 668ac8e Compare April 13, 2026 19:39

// Compare against the expected output file
requireReportEquals(t, "testdata/junit-alerts-output.xml", out.Name())
}
Copy link
Copy Markdown
Contributor Author

@stephanos stephanos Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^ moved this one up here

@stephanos stephanos force-pushed the stephanos/failure-log branch 12 times, most recently from 0fb8162 to 9e6b18d Compare April 13, 2026 20:07
}
sb.WriteString("</td></tr>\n")
return sb.String()
}
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Originally this also added a link to the source code but I removed that for now to reduce scope.

<testsuites tests="1" failures="1">
<testsuite name="ALERTS" tests="1" failures="1" errors="0" id="0" time="">
<testcase name="DATA RACE: Data race detected in TestFoo">
<failure message="DATA RACE" type="DATA RACE"><![CDATA[WARNING: DATA RACE
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One change I made is to standardize on type to identify whether it's a regular assertion failure or one of our "alert" types. It was in message before. Synthetic failures still set both now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant