Signal links#2889
Open
Evanthx wants to merge 12 commits into
Open
Conversation
Comment on lines
+107
to
+111
| public void addSignalWorkflowResponseLink(Link link) { | ||
| if (link != null) { | ||
| this.signalWorkflowResponseLinks.add(link); | ||
| } | ||
| } |
There was a problem hiding this comment.
I'm wondering if this is too operation specific. As more operations include links, we'll keep adding new getters/setters here and then have to ensure they're all consumed when building the StartOperationResponse. A perhaps contrived example would be a nexus operation that signals a workflow, updates a workflow, then starts a workflow would have backlinks for all of those if my understanding is correct.
Contributor
There was a problem hiding this comment.
yeah I would tend to agree, I don't think the context should care what operation decided to attach a link
Contributor
Author
There was a problem hiding this comment.
Renamed to backlinks
…NexusOperationContext.java Co-authored-by: Alex Mazzeo <alex.mazzeo@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sending signals through Nexus now populates a link from the sender to the receiver as well as one from the receiver back to the sender.
What was changed
Why?
Checklist
Closes
How was this tested: