fix(runtime): pass backend generation options#464
Merged
Conversation
tangletools
approved these changes
Jul 3, 2026
tangletools
left a comment
Contributor
There was a problem hiding this comment.
✅ Auto-approved drewstone PR — 6a3b22da
This PR was opened by the trusted drewstone account.
The full PR reviewer audit still runs separately and will publish findings if it detects issues.
tangletools · auto-approval · reason: drewstone_author · 2026-07-03T19:42:36Z
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
temperatureandmaxTokenspassthrough tocreateOpenAICompatibleBackend.resolveAgentBackendfor router/tcloud/cli-bridge paths.maxTokensto OpenAI-compatiblemax_tokensand preserve the existing omitted-field behavior when unset.Why
This closes #460 and lets product/lab callers use the shared backend resolver without losing generation settings needed for fair direct-chat controls.
Verification
pnpm exec biome check --write src/backends.ts src/resolve-agent-backend.ts src/resolve-agent-backend.test.ts tests/backends-openai-tools.test.tspnpm exec vitest run src/resolve-agent-backend.test.ts tests/backends-openai-tools.test.ts— 22 tests passedpnpm typecheckpnpm lintpnpm buildpnpm test— 126 files, 1230 passed, 2 skippedpnpm docs:freshnesspnpm docs:checkgit diff --checkgit fetch origin main && git merge-tree --write-tree origin/main HEAD