feat(campaign): resolve bare runDir to ~/.tangle/traces/<repo>/runs (stop repo-tree pollution)#299
Merged
Merged
Conversation
…stop repo-tree pollution) Campaign/benchmark run bundles were written to a caller-supplied runDir that was often repo-root-relative, so every run littered the working tree with untracked output (product-benchmark-records.jsonl, source-runs/, raw-events/ — what got swept into stashes across repos). Now runCampaign/planCampaignRun resolve a BARE runDir name to the shared, out-of-repo home root ~/.tangle/traces/<repo>/runs/<name>; absolute paths are honored unchanged. Callers pass a name, not a path — bundles never touch a repo tree, no per-repo .gitignore needed. New: resolveRunDir()/tangleTracesRoot() (exported); +repo option. tsc 0; 4/4 tests.
tangletools
approved these changes
Jul 1, 2026
tangletools
left a comment
tangletools
left a comment
Contributor
There was a problem hiding this comment.
✅ Auto-approved drewstone PR — a71a9fc0
This PR was opened by the trusted drewstone account.
The full PR reviewer audit still runs separately and will publish findings if it detects issues.
tangletools · auto-approval · reason: drewstone_author · 2026-07-01T22:15:01Z
drewstone
added a commit
that referenced
this pull request
Jul 1, 2026
Ships resolveRunDir (#299) — bare campaign runDir resolves to ~/.tangle/traces/<repo>/runs, out of repo trees. No breaking changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root fix for the eval-output pollution (the untracked bundles that got swept into stashes across repos). Campaign/benchmark run bundles were written to a caller-supplied
runDir, often repo-root-relative → every run littered the working tree.Now
runCampaign/planCampaignRunresolve a bare runDir name to the shared, out-of-repo home root~/.tangle/traces/<repo>/runs/<name>; absolute paths honored unchanged (explicit override). Callers pass a name, not a path — bundles never touch a repo tree, no per-repo .gitignore needed.resolveRunDir()/tangleTracesRoot()(exported),repo?option.