fix: add runtime.getRandomData import for tinygo v0.37.0+#195
Open
pedramktb wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adds the missing gojs import implementation for runtime.getRandomData in the TinyGo WASM JS shim so TinyGo v0.37.0+ modules can instantiate without a LinkError when the updated tinygo-org/net triggers this runtime import.
Changes:
- Implement
gojs["runtime.getRandomData"]usingcrypto.getRandomValues(...)to fill a WASM-provided byte slice.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pedramktb
force-pushed
the
fix/tinygo-wasm-getRandomData
branch
from
ab92c48 to
1b41bc2
Compare
pedramktb
force-pushed
the
fix/tinygo-wasm-getRandomData
branch
from
1b41bc2 to
18e67c9
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Owner
|
@pedramktb Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TinyGo v0.37.0 updated the net submodule (tinygo-org/net) which introduced
a call to runtime.getRandomData in the compiled wasm binary. Without a
corresponding JS implementation in the gojs import object, instantiating
the module throws:
LinkError: WebAssembly.Instance(): Import # 17 "gojs" "runtime.getRandomData":
function import requires a callable
The addition is already present at the official go runtime package, though the same is missing on TinyGo.
Corresponding PR on TinyGo: tinygo-org/tinygo#5363.