Downgrading virtus as newer version cause problems with other apps that ...#57
Open
peakxu wants to merge 1 commit into
Open
Downgrading virtus as newer version cause problems with other apps that ...#57peakxu wants to merge 1 commit into
peakxu wants to merge 1 commit into
Conversation
…at depend on this
Contributor
|
I'm really not convinced that this is the path forward. What specific conflicts was this causing? |
Contributor
Author
|
This was conflicting with about 5-6 gems dependencies of Swipely app when I was trying to use Hadooply in Swipely app (since Hadooply depends on Pipely). Perhaps the best way forward is to break Hadooply's dependence on Pipely? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...depend on this
@mattgillooly, please review.
Context:
We have quite a few gems which depend upon Virtus 0.5.5. It feels simpler to temporarily downgrade this rather than try to upgrade all of them.