-
Notifications
You must be signed in to change notification settings - Fork 3
feat(ios): update for 4.16.1 #236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,6 +7,16 @@ description: "Release notes for the Superwall iOS SDK" | |
|
|
||
| The changelog for `SuperwallKit`. Also see the [releases](https://github.com/superwall/Superwall-iOS/releases) on GitHub. | ||
|
|
||
| ## 4.16.1 | ||
|
|
||
| ### Enhancements | ||
|
|
||
| - Clarifies that `IntegrationAttribute.onesignalId` should be set to the OneSignal User ID used by the OneSignal integration. | ||
|
|
||
| ### Fixes | ||
|
|
||
| - Makes sure that the compiler directive is correct for billing plan types so that the SDK builds in Xcode version 26.4. | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
The 4.16.1 release note calls out fixing the compiler directive for billing plan types, but the docs sample in Useful? React with 👍 / 👎. |
||
|
|
||
| ## 4.16.0 | ||
|
|
||
| ### Enhancements | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -101,6 +101,6 @@ If you have feedback on any of our docs, please leave a rating and message at th | |
| If you have any issues with the SDK, please [open an issue on GitHub](https://github.com/superwall/superwall-ios/issues). | ||
|
|
||
| <SdkLatestVersion | ||
| version="4.15.4" | ||
| version="4.16.1" | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Bumping the SDK reference to 4.16.1 brings in the 4.16.0 public install-attribution API, but Useful? React with 👍 / 👎. |
||
| repoUrl="https://github.com/superwall/Superwall-iOS" | ||
| /> | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This release note is still the only iOS docs mention of OneSignal;
content/docs/ios/sdk-reference/setIntegrationAttributes.mdxomits.onesignalIdfrom theIntegrationAttributetypes, and a repo-wide search foronesignal|OneSignalin the iOS/shared docs only finds this changelog entry. Because the 4.16.1 upstream change is specifically a customer-facing clarification that the value must be the OneSignal User ID, users looking up how to set integration attributes still will not see the corrected guidance outside the changelog.Useful? React with 👍 / 👎.