-
Notifications
You must be signed in to change notification settings - Fork 3
feat(expo): update for 1.1.6 #225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,77 @@ | ||
| --- | ||
| name: autoreview-sdk-update-pr | ||
| description: Auto-review SDK docs update PRs for ios, android, flutter, expo, or react-native. Use this as a thin autoreview-style wrapper around review-sdk-update-pr: launch fresh read-only reviews, fix only verified findings locally, and repeat until clean. | ||
| --- | ||
|
|
||
| # Auto Review SDK Update PR | ||
|
|
||
| Run an autoreview-style closeout loop for SDK docs update PRs. This skill is only the coordinator; `../review-sdk-update-pr/SKILL.md` is the source of truth for SDK/version/tag/changelog rules, expected docs checks, and verification requirements. | ||
|
|
||
| Use when: | ||
|
|
||
| - user asks for `autoreview-sdk-update-pr` | ||
| - user wants `review-sdk-update-pr` run, valid findings fixed, and the review repeated until clean | ||
| - closing out an SDK docs update PR after CI, bot comments, or manual review notes | ||
|
|
||
| ## Contract | ||
|
|
||
| - Start each review round with a fresh read-only sub-agent. | ||
| - Tell the sub-agent to read and follow `../review-sdk-update-pr/SKILL.md` completely. | ||
| - Treat review output as advisory; verify each finding locally before editing. | ||
| - Fix only concrete, valid issues with minimal local changes. | ||
| - After any fix, run the verification required by `review-sdk-update-pr`, then start another fresh review round. | ||
| - Stop when a fresh review reports no valid remaining issues. | ||
| - Do not commit, push, create a PR, deploy, rerun remote CI, or resolve GitHub threads unless the user explicitly asks. | ||
|
|
||
| ## Inputs | ||
|
|
||
| Collect the inputs needed by `review-sdk-update-pr`: | ||
|
|
||
| 1. SDK | ||
| 2. New version | ||
| 3. Review target: PR number, branch, or current `HEAD` / working tree | ||
| 4. Optional reported issues from user notes, CI notes, GitHub comments, or files under `.context/attachments/comments/` | ||
|
|
||
| If an input cannot be inferred from branch name, changed files, version markers, PR metadata, or user notes, ask one concise question. | ||
|
|
||
| ## Workflow | ||
|
|
||
| 1. Establish the target: | ||
| - Check `git status --short --branch`. | ||
| - Identify the PR/base branch when available. | ||
| - Inspect changed files against the base and note dirty working-tree files. | ||
| - Read any user-provided notes or comment files. | ||
|
|
||
| 2. Launch a fresh read-only review sub-agent with: | ||
| - repository path | ||
| - base branch or comparison ref | ||
| - candidate branch / PR / working tree | ||
| - SDK and new version | ||
| - changed files | ||
| - reported issues, if any | ||
| - instruction to follow `../review-sdk-update-pr/SKILL.md` and end with `Verdict: CLEAN` or `Verdict: NEEDS_WORK` | ||
|
|
||
| 3. Triage the result in the parent session: | ||
| - Accept findings only after verifying them against the repo and upstream SDK references. | ||
| - Reject speculative, stale, already-fixed, duplicated, or out-of-scope findings. | ||
| - Apply minimal local fixes for accepted findings. | ||
|
|
||
| 4. If files changed: | ||
| - Run the verification required by `review-sdk-update-pr`. | ||
| - Start a new fresh review round on the updated working tree. | ||
|
|
||
| 5. Stop when a fresh round is clean. | ||
|
|
||
| ## Final Report | ||
|
|
||
| Include: | ||
|
|
||
| - review target and base | ||
| - number of review rounds | ||
| - final verdict | ||
| - accepted findings and local fixes | ||
| - rejected findings, if any | ||
| - verification results | ||
| - current git status | ||
|
|
||
| State clearly whether any fixes remain local and uncommitted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| ../../.agents/skills/autoreview-sdk-update-pr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the upstream
v1.1.5...v1.1.6diff,android/build.gradlechangescom.superwall.sdk:superwall-androidfrom2.7.15to2.7.16, not2.7.17; leaving this line as-is tells Android Expo users that 1.1.6 includes the 2.7.17 native fixes when it does not. Please align the changelog, or sync it after the upstream changelog is corrected, before publishing.Useful? React with 👍 / 👎.