Stop generating DVD ecc and replace with null bytes

[Sazpaimon]

Maybe one day Omnidrive will let us get this data directly but for now, its better to not generate ECC based on potentially incorrect sector data.

Summary by CodeRabbit

• Bug Fixes
  • Improved frame conversion behavior by no longer altering parity/ECC data during recording frame creation.
  • Recording frames now keep default zeroed parity buffers, while conversion back to data frames remains unchanged.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: b15d980c-bd43-407c-8561-dc8b3a625fc1

📥 Commits

Reviewing files that changed from the base of the PR and between cbf7c9b and 79d12b2.

📒 Files selected for processing (1)

• dvd/dvd.ixx

💤 Files with no reviewable changes (1)

• dvd/dvd.ixx

---

📝 Walkthrough

Walkthrough

In dvd/dvd.ixx, the two internal ECC helper functions compute_parity_inner and compute_parity_outer are deleted, and their call sites inside DataFrame_to_RecordingFrame are removed, leaving RecordingFrame parity buffers zero-initialized.

Changes

ECC Parity Removal

Layer / File(s)	Summary
Delete parity helpers and call sites dvd/dvd.ixx	Removes compute_parity_inner and compute_parity_outer helper definitions and removes the calls that populated parity_inner per row and parity_outer for the frame inside DataFrame_to_RecordingFrame; parity fields now remain at default zero-initialization.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

Poem

🐇 Hop hop, the parity's gone,
No more inner, no outer to don,
Zeroes remain where ECC once grew,
The RecordingFrame wears a simpler hue,
Less math to check—just zeros, adieu! ✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly matches the main change: DVD ECC generation was removed and replaced by zeroed bytes.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}