done?

WallyMaier · WallyMaier · commit ab0680dbdd30 · 2022-12-09T22:30:23.000-05:00
diff --git a/TestCases/aeroelastic/aeroelastic_NACA64A010.cfg b/TestCases/aeroelastic/aeroelastic_NACA64A010.cfg
@@ -36,6 +36,8 @@ REF_DIMENSIONALIZATION= DIMENSIONAL
 TIME_DOMAIN=YES
 TIME_MARCHING= DUAL_TIME_STEPPING-2ND_ORDER
 TIME_STEP= 0.00174532925199
+% 36 steps per period, based on the pitch natural frequency
+%
 MAX_TIME= 50.0
 INNER_ITER= 100
 
diff --git a/TestCases/coupled_cht/comp_2d/cht_2d_3cylinders.cfg b/TestCases/coupled_cht/comp_2d/cht_2d_3cylinders.cfg
@@ -23,6 +23,7 @@ MESH_FORMAT= SU2
 
 % ----------------------- DESIGN VARIABLE PARAMETERS --------------------------%
 %
+% These are just default parameters so that we can run SU2_DOT_AD, they have no physical meaning for this test case.
 DV_KIND= HICKS_HENNE
 DV_MARKER= ( cylinder_outer1, cylinder_inner1, cylinder_outer2, cylinder_inner2, cylinder_outer3, cylinder_inner3  )
 DV_PARAM= (0.0, 0.5)
diff --git a/TestCases/coupled_cht/comp_2d/solid_cylinder1.cfg b/TestCases/coupled_cht/comp_2d/solid_cylinder1.cfg
@@ -23,6 +23,9 @@ MARKER_MONITORING= ( NONE )
 %
 INC_NONDIM= DIMENSIONAL
 FREESTREAM_TEMPERATURE= 350.0
+%
+% Nettis case: hollow cylinder (air w/ 4x the conductivity)
+%
 MATERIAL_DENSITY= 0.000210322
 SPECIFIC_HEAT_CP= 1004.703
 THERMAL_CONDUCTIVITY_CONSTANT= 0.1028
diff --git a/TestCases/coupled_cht/comp_2d/solid_cylinder2.cfg b/TestCases/coupled_cht/comp_2d/solid_cylinder2.cfg
@@ -23,6 +23,9 @@ MARKER_MONITORING= ( NONE )
 %
 INC_NONDIM= DIMENSIONAL
 FREESTREAM_TEMPERATURE= 350.0
+%
+% Nettis case: hollow cylinder (air w/ 4x the conductivity)
+%
 MATERIAL_DENSITY= 0.000210322
 SPECIFIC_HEAT_CP= 1004.703
 THERMAL_CONDUCTIVITY_CONSTANT= 0.1028
diff --git a/TestCases/coupled_cht/comp_2d/solid_cylinder3.cfg b/TestCases/coupled_cht/comp_2d/solid_cylinder3.cfg
@@ -23,6 +23,9 @@ MARKER_MONITORING= ( NONE )
 %
 INC_NONDIM= DIMENSIONAL
 FREESTREAM_TEMPERATURE= 350.0
+%
+% Nettis case: hollow cylinder (air w/ 4x the conductivity)
+%
 MATERIAL_DENSITY= 0.000210322
 SPECIFIC_HEAT_CP= 1004.703
 THERMAL_CONDUCTIVITY_CONSTANT= 0.1028
diff --git a/TestCases/coupled_cht/disc_adj_incomp_2d/cht_2d_3cylinders.cfg b/TestCases/coupled_cht/disc_adj_incomp_2d/cht_2d_3cylinders.cfg
@@ -23,6 +23,7 @@ MESH_FORMAT= SU2
 
 % ----------------------- DESIGN VARIABLE PARAMETERS --------------------------%
 %
+% These are just default parameters so that we can run SU2_DOT_AD, they have no physical meaning for this test case.
 DV_KIND= HICKS_HENNE
 DV_MARKER= ( cylinder_outer1, cylinder_inner1, cylinder_outer2, cylinder_inner2, cylinder_outer3, cylinder_inner3  )
 DV_PARAM= (0.0, 0.5)
diff --git a/TestCases/coupled_cht/disc_adj_incomp_2d/flow_cylinder.cfg b/TestCases/coupled_cht/disc_adj_incomp_2d/flow_cylinder.cfg
@@ -10,6 +10,8 @@
 SOLVER= INC_NAVIER_STOKES
 KIND_TURB_MODEL= NONE
 RESTART_SOL= NO
+
+% Gradient for this test case from direct differentiation (to confirm adjoints results, if desired): -0.716778
 OBJECTIVE_FUNCTION= TOTAL_HEATFLUX
 OBJECTIVE_WEIGHT = 1.0
 READ_BINARY_RESTART = YES
diff --git a/TestCases/coupled_cht/disc_adj_unsteadyCHT_cylinder/chtMaster.cfg b/TestCases/coupled_cht/disc_adj_unsteadyCHT_cylinder/chtMaster.cfg
@@ -63,6 +63,7 @@ FFD_CONTINUITY= NO_DERIVATIVE
 
 % ----------------------- DESIGN VARIABLE PARAMETERS --------------------------%
 %
+% First 9 are upper, second 9 are lower DV's
 DV_KIND= FFD_CONTROL_POINT_2D,FFD_CONTROL_POINT_2D,FFD_CONTROL_POINT_2D,FFD_CONTROL_POINT_2D,FFD_CONTROL_POINT_2D,FFD_CONTROL_POINT_2D,FFD_CONTROL_POINT_2D,FFD_CONTROL_POINT_2D,FFD_CONTROL_POINT_2D, FFD_CONTROL_POINT_2D,FFD_CONTROL_POINT_2D,FFD_CONTROL_POINT_2D,FFD_CONTROL_POINT_2D,FFD_CONTROL_POINT_2D,FFD_CONTROL_POINT_2D,FFD_CONTROL_POINT_2D,FFD_CONTROL_POINT_2D,FFD_CONTROL_POINT_2D
 DV_MARKER= ( cylinder_fluid, cylinder_solid )
 DV_PARAM= \
diff --git a/TestCases/coupled_cht/incomp_2d/cht_2d_3cylinders.cfg b/TestCases/coupled_cht/incomp_2d/cht_2d_3cylinders.cfg
@@ -24,6 +24,7 @@ MESH_FORMAT= SU2
 
 % ----------------------- DESIGN VARIABLE PARAMETERS --------------------------%
 %
+% These are just default parameters so that we can run SU2_DOT_AD, they have no physical meaning for this test case.
 DV_KIND= HICKS_HENNE
 DV_MARKER= ( cylinder_outer1, cylinder_inner1, cylinder_outer2, cylinder_inner2, cylinder_outer3, cylinder_inner3  )
 DV_PARAM= (0.0, 0.5)
diff --git a/TestCases/coupled_cht/incomp_2d_unsteady/solid_cylinder3.cfg b/TestCases/coupled_cht/incomp_2d_unsteady/solid_cylinder3.cfg
@@ -21,6 +21,7 @@ MARKER_MONITORING= ( NONE )
 
 % ---------------- (SOLIDS) CONDUCTION CONDITION DEFINITION -------------------%
 %
+% We should keep the dimensionalization of the coupled flow solver
 INC_NONDIM= DIMENSIONAL
 FREESTREAM_TEMPERATURE= 288.15
 %
@@ -43,7 +44,6 @@ LINEAR_SOLVER_ITER= 5
 
 % -------------------- HEAT NUMERICAL METHOD DEFINITION -----------------------%
 %
-% Time discretization (EULER_IMPLICIT, EULER_EXPLICIT)
 TIME_DISCRE_HEAT= EULER_IMPLICIT
 
 % --------------------------- CONVERGENCE PARAMETERS --------------------------%
diff --git a/TestCases/disc_adj_euler/naca0012_pitching/inv_NACA0012_pitching.cfg b/TestCases/disc_adj_euler/naca0012_pitching/inv_NACA0012_pitching.cfg
@@ -108,7 +108,6 @@ FFD_CONTINUITY= 2ND_DERIVATIVE
 
 % ----------------------- DESIGN VARIABLE PARAMETERS --------------------------%
 %
-FFD_CONTROL_POINT, FFD_CONTROL_POINT, FFD_CONTROL_POINT, FFD_CONTROL_POINT, FFD_CONTROL_POINT, FFD_CONTROL_POINT, FFD_CONTROL_POINT, FFD_CONTROL_POINT, FFD_CONTROL_POINT, FFD_CONTROL_POINT, FFD_CONTROL_POINT, FFD_CONTROL_POINT, FFD_CONTROL_POINT, FFD_CONTROL_POINT, FFD_CONTROL_POINT, FFD_CONTROL_POINT
 DV_KIND= FFD_SETTING
 DV_MARKER= ( airfoil )
 DV_PARAM= ( airfoil_box, 5, 0, 0, 0.0, 1.0, 0.0 )
diff --git a/TestCases/sliding_interface/pipe/zone_1.cfg b/TestCases/sliding_interface/pipe/zone_1.cfg
@@ -14,5 +14,6 @@
 %
 GRID_MOVEMENT= RIGID_MOTION 
 MACH_MOTION= 0.35
+% Angular velocity vector (rad/s) about the motion origi. Example 1250 RPM -> 130.89969389957471 rad/s
 MOTION_ORIGIN= 0.0 0.0 0.0
 ROTATION_RATE = 0.0 0.0 0.0
diff --git a/TestCases/sliding_interface/single_stage/zone_1.cfg b/TestCases/sliding_interface/single_stage/zone_1.cfg
@@ -15,4 +15,5 @@
 GRID_MOVEMENT= RIGID_MOTION
 MACH_MOTION= 0.35
 MOTION_ORIGIN= 0.0 0.0 0.0
+% Angular velocity vector (rad/s) about the motion origi. Example 1250 RPM -> 130.89969389957471 rad/s
 ROTATION_RATE = 0.0 0.0 0.0
diff --git a/TestCases/unsteady/pitching_naca64a010_euler/pitching_NACA64A010.cfg b/TestCases/unsteady/pitching_naca64a010_euler/pitching_NACA64A010.cfg
@@ -20,6 +20,8 @@ RESTART_SOL= NO
 %
 TIME_MARCHING= DUAL_TIME_STEPPING-2ND_ORDER
 TIME_STEP= 0.0023555025613149587
+% 24 steps per period: 0.0024536485013697488
+%
 MAX_TIME= 0.59
 INNER_ITER= 110
 UNST_ADJOINT_ITER= 251
diff --git a/TestCases/unsteady/pitching_naca64a010_rans/turb_NACA64A010.cfg b/TestCases/unsteady/pitching_naca64a010_rans/turb_NACA64A010.cfg
@@ -20,6 +20,9 @@ RESTART_SOL= NO
 %
 TIME_MARCHING= DUAL_TIME_STEPPING-2ND_ORDER
 TIME_STEP= 0.0023555025613149587
+% 24 steps per period: 0.0024536485013697488
+% 25 steps per period: 0.0023555025613149587
+%
 MAX_TIME= 0.59
 INNER_ITER= 2000
 UNST_ADJOINT_ITER= 251
diff --git a/TestCases/unsteady/plunging_naca0012/plunging_NACA0012.cfg b/TestCases/unsteady/plunging_naca0012/plunging_NACA0012.cfg
@@ -20,6 +20,9 @@ RESTART_SOL= NO
 %
 TIME_MARCHING= DUAL_TIME_STEPPING-2ND_ORDER
 TIME_STEP= 0.0023555025613149587
+% 24 steps per period: 0.0024536485013697488
+% 25 steps per period: 0.0023555025613149587
+%
 MAX_TIME= 0.5888756403287397
 INNER_ITER= 1000
 

Original file line number	Diff line number	Diff line change
`@@ -23,6 +23,7 @@ MESH_FORMAT= SU2`
`23`	`23`
`24`	`24`	`% ----------------------- DESIGN VARIABLE PARAMETERS --------------------------%`
`25`	`25`	`%`
	`26`	`+% These are just default parameters so that we can run SU2_DOT_AD, they have no physical meaning for this test case.`
`26`	`27`	`DV_KIND= HICKS_HENNE`
`27`	`28`	`DV_MARKER= ( cylinder_outer1, cylinder_inner1, cylinder_outer2, cylinder_inner2, cylinder_outer3, cylinder_inner3 )`
`28`	`29`	`DV_PARAM= (0.0, 0.5)`
Original file line number	Diff line number	Diff line change
`@@ -63,6 +63,7 @@ FFD_CONTINUITY= NO_DERIVATIVE`
`63`	`63`
`64`	`64`	`% ----------------------- DESIGN VARIABLE PARAMETERS --------------------------%`
`65`	`65`	`%`
	`66`	`+% First 9 are upper, second 9 are lower DV's`
`66`	`67`	`DV_KIND= FFD_CONTROL_POINT_2D,FFD_CONTROL_POINT_2D,FFD_CONTROL_POINT_2D,FFD_CONTROL_POINT_2D,FFD_CONTROL_POINT_2D,FFD_CONTROL_POINT_2D,FFD_CONTROL_POINT_2D,FFD_CONTROL_POINT_2D,FFD_CONTROL_POINT_2D, FFD_CONTROL_POINT_2D,FFD_CONTROL_POINT_2D,FFD_CONTROL_POINT_2D,FFD_CONTROL_POINT_2D,FFD_CONTROL_POINT_2D,FFD_CONTROL_POINT_2D,FFD_CONTROL_POINT_2D,FFD_CONTROL_POINT_2D,FFD_CONTROL_POINT_2D`
`67`	`68`	`DV_MARKER= ( cylinder_fluid, cylinder_solid )`
`68`	`69`	`DV_PARAM= \`
Original file line number	Diff line number	Diff line change
`@@ -24,6 +24,7 @@ MESH_FORMAT= SU2`
`24`	`24`
`25`	`25`	`% ----------------------- DESIGN VARIABLE PARAMETERS --------------------------%`
`26`	`26`	`%`
	`27`	`+% These are just default parameters so that we can run SU2_DOT_AD, they have no physical meaning for this test case.`
`27`	`28`	`DV_KIND= HICKS_HENNE`
`28`	`29`	`DV_MARKER= ( cylinder_outer1, cylinder_inner1, cylinder_outer2, cylinder_inner2, cylinder_outer3, cylinder_inner3 )`
`29`	`30`	`DV_PARAM= (0.0, 0.5)`
Original file line number	Diff line number	Diff line change
`@@ -21,6 +21,7 @@ MARKER_MONITORING= ( NONE )`
`21`	`21`
`22`	`22`	`% ---------------- (SOLIDS) CONDUCTION CONDITION DEFINITION -------------------%`
`23`	`23`	`%`
	`24`	`+% We should keep the dimensionalization of the coupled flow solver`
`24`	`25`	`INC_NONDIM= DIMENSIONAL`
`25`	`26`	`FREESTREAM_TEMPERATURE= 288.15`
`26`	`27`	`%`
`@@ -43,7 +44,6 @@ LINEAR_SOLVER_ITER= 5`
`43`	`44`
`44`	`45`	`% -------------------- HEAT NUMERICAL METHOD DEFINITION -----------------------%`
`45`	`46`	`%`
`46`		`-% Time discretization (EULER_IMPLICIT, EULER_EXPLICIT)`
`47`	`47`	`TIME_DISCRE_HEAT= EULER_IMPLICIT`
`48`	`48`
`49`	`49`	`% --------------------------- CONVERGENCE PARAMETERS --------------------------%`