Skip to content

dtostrf should not print fractional part if prec is 0 #1268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fpistm merged 1 commit into from
Dec 22, 2020
Merged

dtostrf should not print fractional part if prec is 0 #1268

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 19 additions & 11 deletions cores/arduino/avr/dtostrf.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,19 +49,27 @@ char *dtostrf(double val, signed char width, unsigned char prec, char *sout)
unsigned long int_part = (unsigned long)val;
double remainder = val - (double)int_part;

// Extract digits from the remainder
unsigned long dec_part = 0;
double decade = 1.0;
for (int i = 0; i < prec; i++) {
decade *= 10.0;
}
remainder *= decade;
dec_part = (int)remainder;
if (prec > 0) {
// Extract digits from the remainder
unsigned long dec_part = 0;
double decade = 1.0;
for (int i = 0; i < prec; i++) {
decade *= 10.0;
}
remainder *= decade;
dec_part = (int)remainder;

if (negative) {
sprintf(sout, "-%ld.%0*ld", int_part, prec, dec_part);
if (negative) {
sprintf(sout, "-%ld.%0*ld", int_part, prec, dec_part);
} else {
sprintf(sout, "%ld.%0*ld", int_part, prec, dec_part);
}
} else {
sprintf(sout, "%ld.%0*ld", int_part, prec, dec_part);
if (negative) {
sprintf(sout, "-%ld", int_part);
} else {
sprintf(sout, "%ld", int_part);
}
}
// Handle minimum field width of the output string
// width is signed value, negative for left adjustment.
Expand Down