cherry: dont send net-connection for sinkhole ip, bump armour and go-version#482
Open
h0x0er wants to merge 1 commit into
Open
cherry: dont send net-connection for sinkhole ip, bump armour and go-version#482h0x0er wants to merge 1 commit into
h0x0er wants to merge 1 commit into
Conversation
* dont send net-connection for sinkhole ip * bump armour to v1.2.4 * armour: bump to v1.4.0 * bump go version to 1.26.2
There was a problem hiding this comment.
Pull request overview
This PR updates the agent’s networking telemetry behavior to avoid reporting connections to the StepSecurity DNS sinkhole IP (used during DNS blocking), and bumps the Go toolchain plus several dependencies (including github.com/step-security/armour).
Changes:
- Skip handling of network events targeting
StepSecuritySinkHoleIPAddressinhandleNetworkEvent. - Bump Go version to
1.26.2and upgradegithub.com/step-security/armourtov1.4.0(plus relatedgolang.org/x/*updates). - Update GitHub Actions workflows to use Go
1.26.2.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
eventhandler.go |
Adds sinkhole IP short-circuit and adjusts net-connection reporting logic. |
go.mod |
Bumps Go version and updates module requirements (notably armour). |
go.sum |
Updates checksums to match new dependency versions. |
.github/workflows/test.yml |
Uses Go 1.26.2 in CI. |
.github/workflows/release.yml |
Uses Go 1.26.2 for release workflow. |
.github/workflows/int.yml |
Uses Go 1.26.2 for integration workflow. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| func (eventHandler *EventHandler) handleNetworkEvent(event *Event) { | ||
|
|
||
| // sinkhole is returned in-case of dns-block |
Comment on lines
+167
to
+170
| // sinkhole is returned in-case of dns-block | ||
| if event.IPAddress == StepSecuritySinkHoleIPAddress { | ||
| return | ||
| } |
Comment on lines
200
to
+202
| reverseLookUp := eventHandler.DNSProxy.GetReverseIPLookup(event.IPAddress) | ||
| status := "" | ||
| matchedPolicy := "" | ||
| reason := "" | ||
| if eventHandler.DNSProxy.GlobalBlocklist != nil && eventHandler.DNSProxy.GlobalBlocklist.IsIPAddressBlocked(event.IPAddress) { | ||
| status = "Dropped" | ||
| matchedPolicy = GlobalBlocklistMatchedPolicy | ||
| reason = eventHandler.DNSProxy.GlobalBlocklist.BlockedIPAddressReason(event.IPAddress) | ||
| } | ||
| eventHandler.ApiClient.sendNetConnection(eventHandler.CorrelationId, eventHandler.Repo, event.IPAddress, event.Port, reverseLookUp, status, matchedPolicy, reason, event.Timestamp, tool) | ||
| eventHandler.ApiClient.sendNetConnection(eventHandler.CorrelationId, eventHandler.Repo, event.IPAddress, event.Port, reverseLookUp, "", "", "", event.Timestamp, tool) | ||
|
|
Comment on lines
+167
to
+170
| // sinkhole is returned in-case of dns-block | ||
| if event.IPAddress == StepSecuritySinkHoleIPAddress { | ||
| return | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.