Synchronise master with upstream#562
Merged
Merged
Conversation
Add support for installing extra Kolla Ansible collections from
kolla/requirements.yml files discovered in ${KAYOBE_CONFIG_PATH} and
kayobe_env_search_paths when they exist.
This supports use cases such as shipping custom filter plugins in a
private collection and using those filters in Kolla configuration
templates.
Change-Id: I3ab75766d23ea06852c494806e5230ad20c779ca
Signed-off-by: Will Szumski <will@stackhpc.com>
There is no point using the cached filter here since vars is not an expensive external lookup. Closes-Bug: #2138614 Change-Id: Ieddb9b48f5e10de26dced947f9e1d7d4276e4448 Signed-off-by: Will Szumski <will@stackhpc.com>
Expose the Ironic auto-discovery node driver used by Bifrost via a new kolla_bifrost_inspector_default_node_driver variable. This maps to inspector_default_node_driver in bifrost.yml, which sets [auto_discover] driver in ironic.conf. The default is unset, preserving Bifrost's existing default of ipmi. Operators can set this to redfish for modern BMC implementations without relying on workarounds. Closes-Bug: #2137417 Change-Id: I48ccf4fb40036ca25cd00050342fbd0b6e6cfad2 Signed-off-by: Will Szumski <will@stackhpc.com>
This patch adds functionality to enroll baremetal nodes in Bifrost using the Kayobe CLI `kayobe overcloud hardware register` similar to the registration workflow available in Overcloud Ironic using 'kayobe baremetal compute register'. Co-Authored-By: Matt Anson <matta@stackhpc.com> Change-Id: I412cf9ccf4c41c89405c904b41b04e64f234e7de Signed-off-by: Hollie Hutchinson <hollie@stackhpc.com>
Skip ansible/collections in bashate and bandit runs. These files come from downloaded Ansible Galaxy collections rather than tracked repo content, and can cause pep8 failures due to upstream issues. Change-Id: If0fe3c6153131bcdea5ee888a61843df62b8b94c Signed-off-by: Grzegorz Koper <grzegorzk@stackhpc.com>
This fixes overcloud service deployment when using Kolla images from quay.io [1], as done in CI jobs. [1] https://review.opendev.org/c/openstack/kolla-ansible/+/986050 Change-Id: Ie7a63612e54e7ccbd375a54f6954afa8a0b2289b Signed-off-by: Pierre Riteau <pierre@stackhpc.com>
Replace direct access to deprecated internal attributes with supported public APIs, targeting removal in ansible-core 2.23: - Replace _available_variables with available_variables property - Replace direct environment.loader.searchpath assignment with copy_with_new_env() to set a custom template searchpath https://docs.ansible.com/ansible-core/devel/porting_guides/porting_guide_core_2.19.html#plugin-api Change-Id: I24459dbae8906cbe2c6d807d2b9a0314dc1eb2ca Signed-off-by: Will Szumski <will@stackhpc.com>
Fix conditionals that resolve to non-boolean types, which will be removed in ansible-core 2.23: - ip-allocation.yml: use 'is falsy' test for net_no_ip filter result which returns None or a string - ipa-images/tasks/main.yml: add explicit bool conversion to string-valued conditionals - network-connectivity.yml: use 'is truthy' test for net_ip and net_gateway filter results which return strings or None - dell-switch-bmp.yml: use 'is truthy' test for list-valued dell_switch_bmp_images conditional https://docs.ansible.com/ansible-core/devel/porting_guides/porting_guide_core_2.19.html#broken-conditionals https://docs.ansible.com/ansible-core/devel/porting_guides/porting_guide_core_2.19.html#noteworthy-plugin-changes Change-Id: Ie8fbc96c4ecb7d18ccc97a2c180ac783584e87d1 Signed-off-by: Will Szumski <will@stackhpc.com>
Rename task-scoped vars 'name' and 'port' to 'node_name' and 'node_port' in the 'Set IPMI serial console terminal port' task to avoid Ansible warnings about reserved variable names. Change-Id: I61db01bbc0e3220ac496d433e16385b5d0a617da Signed-off-by: Will Szumski <will@stackhpc.com>
Replace 'play_hosts' with 'ansible_play_batch', which is the supported replacement. 'play_hosts' is removed in ansible-core 2.23. https://docs.ansible.com/ansible-core/devel/porting_guides/porting_guide_core_2.19.html#deprecation-warnings-on-value-access Change-Id: I397158f43a7fe4ea52c3888001fe0cd82b2b6444 Signed-off-by: Will Szumski <will@stackhpc.com>
Depends-On: https://review.opendev.org/c/openstack/kayobe-config-dev/+/972842 Change-Id: I3f33b6471313a9a9ebfa679f4a9028547b0dec30 Signed-off-by: Pierre Riteau <pierre@stackhpc.com> Signed-off-by: Will Szumski <will@stackhpc.com> Signed-off-by: Matt Crees <mattc@stackhpc.com>
Causes sudo to emit warnings:
stdout: |-
sudo: unable to resolve host npc6051c5f02124: Name or service not known
{"changed": true}
This extra stdout output prevents Ansible JSON parsing despite
successful task execution.
Change-Id: Icfa141b69a9d90d5ee1c44acea50d0813c5c1537
Signed-off-by: Will Szumski <will@stackhpc.com>
Rocky Linux introduced a new security repository [1]. Add support for templating its configuration file. [1] https://forums.rockylinux.org/t/rocky-linux-security-repository-and-dirty-frag-security-update/20435 Change-Id: I974055f08ed5f0a548168b031f7e3ad3c0bb2545 Signed-off-by: Pierre Riteau <pierre@stackhpc.com>
Quote driver-info and property arguments when creating baremetal nodes. This fixes registration with complex passwords containing characters like ), &, $, spaces, or quotes. Closes-Bug: #2152538 Change-Id: I9d63881f03ae45c84eec90fd2c9a29c985a17bbc Signed-off-by: Bartosz Bezak <bartosz@stackhpc.com>
Follow up to the earlier fix for overcloud Ironic[1]. Extends the fix to the recently introduced bifrost registration playbooks. [1] https://review.opendev.org/c/openstack/kayobe/+/988432 Change-Id: I958206bbfb0db7b859412fb49c2af892e8c4521c Signed-off-by: Will Szumski <will@stackhpc.com>
Use explicit boolean tests in the network-nmstate zone map loop conditions to avoid ansible-core broken-conditional failures when filters return None or strings. https: //docs.ansible.com/ansible-core/devel/porting_guides/porting_guide_core_2.19.html#broken-conditionals Change-Id: I3ffd5691603a49361fc7a9f16cfccd5cc0f0415e Signed-off-by: Will Szumski <will@stackhpc.com>
Change-Id: I65ea59693acc359fcf4062e9a94a1d73f82c86b0 Signed-off-by: Will Szumski <will@stackhpc.com>
Let's warn people to update their playbooks before completely dropping this. Change-Id: Ia7c2eacb01f393534054e547b31664e19cac2477 Signed-off-by: Will Szumski <will@stackhpc.com>
Following the steps in the Kayobe release guide[1,2] [1] https://docs.openstack.org/kayobe/latest/contributor/releases.html#synchronise-with-kolla-ansible-feature-flags [2] https://docs.openstack.org/kayobe/latest/contributor/releases.html#synchronise-with-kolla-ansible-inventory Change-Id: I4ef8f0b472801e8fc168dee91c73fc0fa5c02c89 Signed-off-by: Will Szumski <will@stackhpc.com>
We still seem to be seeing failures with the following signature:
Failed to download packages: No URLs in mirrorlist
This extends the previous change[1] to all repos.
[1] https://review.opendev.org/c/openstack/kayobe/+/983990
Change-Id: Ie1fc5c55137e985a21aeb97507c7efe9ec9b5336
Signed-off-by: Will Szumski <will@stackhpc.com>
added 8 commits
May 14, 2026 12:10
github-actions
Bot
added
automated
Alex-Welsh
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains a snapshot of master from upstream master.