fix: redact pkcs12 password in logs#706
Merged
Merged
Conversation
01f81a6 to
ca80f0c
Compare
ca80f0c to
6952829
Compare
Techassi
reviewed
May 18, 2026
Member
Techassi
left a comment
There was a problem hiding this comment.
LGTM, nice catch!
One suggestion about Default on Unloggable.
Techassi
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The CSI
node_publish_volumehandler logs the fullSecretVolumeSelectorin theissuing secret for PodINFOevent.CompatibilityOptionsderivedDebug, so the user-provided PKCS#12 keystore password (from thesecrets.stackable.tech/format.compatibility.tls-pkcs12.passwordvolume attribute) was written to operator stdout in cleartext on every successful mount.tls_pkcs12_passwordis now wrapped with the existingUnloggable<T>wrapper.Reproduction
Mount a
tls-pkcs12volume with the password annotation:Before:
After:
Definition of Done Checklist
Author
Reviewer
Acceptance
type/deprecationlabel & add to the deprecation scheduletype/experimentallabel & add to the experimental features tracker