fix: stop GetIP erroring when the IP flag has a nil default#479
Closed
leno23 wants to merge 1 commit into
Closed
Conversation
|
wuyangfan seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Collaborator
|
@leno23 if you don't sign the CLA I will implement automation that automatically closes any PRs from you. Please stop spamming. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #478
Fixes #351
When an
IPflag defaults tonil,GetIPround-trips throughValue.String()and receives"<nil>", whichipConvrejected.Set("")already treats empty input as "no IP"; this mirrors that on the read side by returning(net.IP(nil), nil)for""and"<nil>".Test plan
TestGetIPNilDefaultcoveringIPandIPVarwith a nil defaultgo test ./...Made with Cursor