pure-docker: add postgres configuration file mounts#806
Open
kevinwojo wants to merge 2 commits into
Open
Conversation
caugustus-sourcegraph
approved these changes
Apr 26, 2022
| -e POSTGRES_USER=postgres \ | ||
| -e PGDATA=/var/lib/postgresql/data/pgdata \ | ||
| -v $VOLUME:/var/lib/postgresql/data/ \ | ||
| -v $PWD/../codeinsights-db/conf:/conf \ |
Contributor
There was a problem hiding this comment.
Suggested change
| -v $PWD/../codeinsights-db/conf:/conf \ | |
| -v $(pwd)/../codeinsights-db/conf:/conf \ |
Not sure it really matters but we use this syntax in deploy-grafana / deploy-prometheus. Full disclosure: I can't remember which approach is more universal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bind mount the postgres configuration file to allow admins to tune their databases in the pure-docker deployment.
See: https://github.com/sourcegraph/customer/issues/854
Checklist
Test plan
Manual testing
manual test result
successful creation of mount
correct file copied into postgres data dir