Skip to content

Add identity gdpr erasure#1804

Draft
jamessnowplow wants to merge 1 commit into
mainfrom
feat/identity-erasure
Draft

Add identity gdpr erasure#1804
jamessnowplow wants to merge 1 commit into
mainfrom
feat/identity-erasure

Conversation

@jamessnowplow

Copy link
Copy Markdown
Contributor

What changed?

Added identity erasure docs.

Reviewer guidance

Only a draft until we surface the urls in console.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented May 26, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
documentation 6d5aa80 Commit Preview URL

Branch Preview URL
May 26 2026, 10:55 AM

@claude

claude Bot commented May 26, 2026

Copy link
Copy Markdown

Documentation style review

A few items to address — mostly minor, plus one merge-blocker the author already flagged.

1. "fulfil" → "fulfill" (US spelling)

"to fulfil a GDPR right-to-erasure request"
"to fulfil GDPR right-to-erasure requests"
"To fulfil the request, you must also delete..."
description: "Erase a user's entries from the Snowplow Identities graph to fulfil a GDPR right-to-erasure request."

CLAUDE.md → Writing style: "Use US English spelling." The US form is fulfill (double L). Replace each instance in docs/identities/erasure/index.md (intro, warning admonition, "Make an erasure request" intro, and the frontmatter description).

2. Bold used for non-UI emphasis

  • 100 combined inputs (identifiers plus snowplow_ids)
  • 256 KB request body

CLAUDE.md → Grammar and formatting: "Use bold only for UI elements (buttons, page titles)." The style guide reinforces this (bold = buttons, page titles, tabs, menus). These are values, not UI elements — drop the bold:

- 100 combined inputs (`identifiers` plus `snowplow_ids`)
- 256 KB request body

3. Pending "do not merge" gate

{/* TODO: do not merge this page to main until Console > Identities > Overview surfaces the API URL referenced in the Authenticate section. */}

Outside pure style scope, but worth surfacing: the author has marked the page as not-ready-to-merge until Console exposes the API URL the Authenticate section sends readers to find. Either resolve that dependency or convert this into a draft/hold before merge. Also remove the comment once the gate clears.

4. Minor: heading voice

## Fulfilling GDPR erasure requests (in docs/identities/index.md)

CLAUDE.md → Headings and organization: "Prefer imperative voice." Consider ## Fulfill GDPR erasure requests (and fix the spelling per item 1).


Otherwise the page is well-structured: frontmatter is complete, internal links use absolute paths ending in /index.md, H2 count is within range, terminology (entity, identity graph, lowercased concepts) matches the guide, and the request/response examples are consistent between dry-run and real-erasure sections. No external URLs were added that needed link-checking.

@jamessnowplow jamessnowplow force-pushed the feat/identity-erasure branch from 88680be to 6d5aa80 Compare May 26, 2026 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant