Fix: Restore Core Eluna APIs (Gossip/Summon) & Enable Non-destructive Spell Hooks#57
Open
ttklmnt wants to merge 3 commits into
Open
Fix: Restore Core Eluna APIs (Gossip/Summon) & Enable Non-destructive Spell Hooks#57ttklmnt wants to merge 3 commits into
ttklmnt wants to merge 3 commits into
Conversation
Author
|
Hi, I noticed the Clang / build check failed. However, the error seems to be caused by an unused parameter pos in Pathfinding.h and some pre-existing OpenSSL deprecation warnings triggered by -Werror. Since these are unrelated to my Bot AI fixes, I didn't modify them to avoid touching the core architecture. Please let me know if you want me to bypass the warning in this PR, or if you will handle it separately. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR restores several critical missing linkages in the 7.3.5 Eluna engine implementation, enabling developers to create complex custom features (such as a "Multi-function Hearthstone Menu") while maintaining strict compatibility with default retail behaviors.
Key Restorations & Fixes:
sEluna->OnGossipSelectinNPCHandler.cpp. Previously, menu clicks lacking strict Unit data were dropped by the ScriptMgr, causing Eluna gossip scripts to silently fail.OnChatbridge inSpell.cppto broadcast an internal signal (e.g., Hearthstone8690cast initialization).SpellHistory->ResetCooldowninHandleGossipHelloOpcodeto clear phantom client-side item cooldowns triggered when Lua scripts manually interrupt items like the Hearthstone.SummonCreaturework as intended without silent crashes.Implementation Note:
The primary/core functionalities of the Eluna engine are now robust and stable for major script development. However, please note that some edge-case APIs or minor hooks may still require further patching by the community in the future.
Testing: Compiled and tested in-game. Custom Lua gossip menus now trigger 100% reliably. Vanilla spell casting remains unaffected when Lua scripts are absent.
This PR provides the necessary C++ hooks in the core. However, to fully utilize features like
SummonCreaturein Lua scripts, modifications to the Eluna Engine source itself were also required (as the default Eluna branch for 7.x lacks/has broken implementations for some entity spawning APIs).For anyone testing this PR or looking to implement advanced custom menus, I have published the restored Eluna API source files (with the missing Summon functions fixed) in my own repository here:
https://github.com/ttklmnt/Eluna-7.3.5-Fixed