Fix nightly sklearn pin#520
Merged
Merged
Conversation
The scientific-python-nightly-wheels index no longer publishes scikit-learn 1.9.dev0, so pixi fails to solve the `default` and `ci-sklearn-nightly` environments. Since every CI job resolves the `default` environment, this broke all of CI (e.g. PR skops-dev#519). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Now that scikit-learn 1.9.0 is released and nightly tracks 1.10.dev0, add a ci-sklearn19 environment/feature and wire it into the build-test matrix so the latest stable release is covered. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Newer pytest (preparing for pytest 10) deprecates passing a non-Collection iterable (here, generators) to @pytest.mark.parametrize, raising PytestRemovedIn10Warning. skops treats DeprecationWarning as an error, so this aborted collection of test_persist.py and failed every CI environment. Wrap the _tested_estimators/_tested_ufuncs/_tested_types/_unsupported_estimators generators in list(). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
matplotlib deprecated boxplot's `vert` (bool) in 3.11 (removed in 3.13) in
favour of `orientation` ({'vertical','horizontal'}); with skops treating
DeprecationWarning as an error this failed the permutation-importance card
tests on every CI environment.
The previous `vert="horizontal"` was also a latent bug: `vert` is boolean, so
the truthy string rendered the boxplot vertically rather than horizontally.
Teach the boxplot() shim to pick `orientation=` on matplotlib >=3.10 and fall
back to `vert=` (bool) on older versions, and pass orientation="horizontal"
from the card so the plot is horizontal as originally intended.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
test_copy_plots saved one plot to a relative "fig2.png" path, which wrote it into the current working directory (the repo root) and left it behind. Save it into the test's temporary directory like fig1, so it is cleaned up with it. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
adrinjalali
force-pushed
the
fix-nightly-sklearn-pin
branch
from
0d8dd4c to
aa1d878
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update ci