[profiles] Remove Profiles.#11476
Open
renanthera wants to merge 2 commits into
Open
Conversation
…TODO: Create a new home for them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be merged no sooner than 12.1 in order to give consumers time to switch over.
Maintainers seem to either have a strong dislike for profiles or don't care all that much either way. Profiles do serve a purpose for tools like Bloodmallet, Liquidarmory, guide websites and possibly for others.
Rehoming them under a new repository such as
simulationcraft/simc-profilesor entirely unrelated to the organization would likely be desired. I would support the former solution.Comments are desired with regards to whether or not this PR gets merged, where profiles would end out, and potential format changes.