Skip to content

feat(devtui): modal value picker and overlay restructure#988

Merged
Soner (shyim) merged 1 commit intonextfrom
feat/devtui-config-modal-picker
May 8, 2026
Merged

feat(devtui): modal value picker and overlay restructure#988
Soner (shyim) merged 1 commit intonextfrom
feat/devtui-config-modal-picker

Conversation

@shyim
Copy link
Copy Markdown
Member

Summary

  • Replace inline ←/→ cycling on the Config tab with a centered Enter-to-open modal picker (list for selects, text input for credentials).
  • Introduce a Modal interface and route the command palette, value picker, and stop-confirm dialog through it; lifecycle phases (Docker start/stop, install, task runner) remain separate.
  • Split model_update.go (565 → 185 lines) into lifecycle.go, install_wizard.go, task_runner.go, keys.go, and overlay_*.go so each file owns one concern.

Test plan

  • Open the Config tab, press Enter on PHP Version / Profiler / Node Version — list modal appears, ↑/↓ chooses, Enter confirms, Esc cancels.
  • Switch profiler to Blackfire/Tideways, press Enter on a credential field — text modal appears, Enter saves the value.
  • Save & Regenerate still works (Enter on the Save row when modified).
  • Ctrl+P opens the command palette and executing a command still works.
  • In Docker mode, q / Ctrl+C still triggers the stop-confirm dialog.

Pressing Enter on a Config tab field now opens a centered modal
(list picker for selects, text input for credentials) instead of
cycling inline. ←/→ cycle is removed.

Internally, dismissable overlays (palette, picker, stop-confirm)
are unified behind a Modal interface separate from lifecycle phases,
and model_update.go is split into lifecycle.go, install_wizard.go,
task_runner.go, keys.go, and overlay_*.go so each file has one
purpose and adding a new tab/modal/phase touches one place.
@shyim Soner (shyim) marked this pull request as ready for review May 8, 2026 09:18
@shyim Soner (shyim) merged commit 8ead264 into next May 8, 2026
2 checks passed
@shyim Soner (shyim) deleted the feat/devtui-config-modal-picker branch May 8, 2026 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant