feat: upgrade vue-i18n to v10#1016
Draft
Bojan Rajh (bojanrajh) wants to merge 1 commit intomainfrom
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Bojan Rajh (bojanrajh)
requested review from
Nils Haberkamp (Haberkamp) and
Jannis Leifeld (jleifeld)
Contributor
Author
|
Closing in favour of #1046 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Upgrades
vue-i18nfromv9tov10- both enter end of maintenance period in 1 day: https://vue-i18n.intlify.dev/guide/maintenance.html .Why?
Meteor component library introduced multiple breaking changes in
v4.24.0(#979). This seems to solve one issue. There's still an issue withmt-text-editoremitting tailwind css reset and other CSS.Seems related to
import "@git-diff-view/vue/styles/diff-view.css";in #932, but we don't usemt-text-editornormt-text-editor-diff-modal.Seems related to new bundling: some global CSS is auto-imported simply by calling
import { AnyFoo } from '@shopware-ag/meteor-component-library', without ever using theAnyFoo. The situation gets worse when the component is actually registered withapp.component('AnyFoo', AnyFoo).How?
Testing?
Local
pnpm link+pnpm build.Screenshots (optional)
Anything Else?
Alternatively, we can keep bundling
vue-i18nas in this branch: main...dx/fix-bundleSee discussion #979 (comment)